Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The UrlInput icon button doesn't have any accessible name #1854

Closed
afercia opened this issue Jul 11, 2017 · 1 comment
Closed

The UrlInput icon button doesn't have any accessible name #1854

afercia opened this issue Jul 11, 2017 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jul 11, 2017 •
edited
Loading

The UrlInput added in 4dc462c doesn't have any text or aria-label, is completely "empty" and there's nothing assistive technologies can announce.
It needs an aria-label attribute with a meaningful text.

Edit: as per the title, this issue is about the UrlInput icon button.
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 11, 2017
@prtksxna prtksxna mentioned this issue Jul 11, 2017
Merged
@afercia
Copy link
Contributor Author

afercia commented Aug 1, 2017

The UrlInput has been significantly refactored and this doesn't apply any longer.

@afercia afercia closed this as completed Aug 1, 2017
@afercia afercia mentioned this issue Sep 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afercia