Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation choose pattern of adding a new link #18830

Closed
karmatosed opened this issue Nov 29, 2019 · 7 comments
Closed

Navigation choose pattern of adding a new link #18830

karmatosed opened this issue Nov 29, 2019 · 7 comments
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@karmatosed
Copy link
Member

Currently there are 2 different patterns of adding links:

  • Clicking '+'
  • Clicking sub nav link

When you are at the top level, to add a sub nav you can only click the sub nav link. However, when you are in the sub nav a '+' icon shows.

image

The confusing point is that of course, you can add a sub to the 2nd level item, making a 3rd level menu. However, this reads a little confusing.

The entire thing can get really complicated to navigate visually if you see the top level:

image

I would suggest we need to only show 2 clear ways of adding things by default and look at how we can focus depending on where you are.

@karmatosed karmatosed added the [Feature] List View Menu item in the top toolbar to select blocks from a list of links. label Nov 29, 2019
@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Nov 29, 2019
@karmatosed
Copy link
Member Author

This also gets worse the more sub nav you have:

image

@yunjuc
Copy link

yunjuc commented Dec 7, 2019

First time commenting so hope I didn't miss information from other discussions.

I agree many sub nav "+" together is confusing. How about not having the sub nav "+" at all? I saw the sub nav "+" only shows up after the second level, which means when users start using the sub nav "+", they also know how to use the sub nav link.

Having only one way to add sub nav also makes "+" icon less ambiguous - "+" is for new link and sub nav icon is for sub nav.

@shaunandrews
Copy link
Contributor

Maybe we take a cue from the Block Navigator UI and add some structural indicators for sub-navs:

image

@karmatosed
Copy link
Member Author

I like that @shaunandrews, let's explore this in a PR and then see what it feels like. Removing design feedback to progress.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Dec 18, 2019
@apeatling
Copy link
Contributor

Related: #18333

@getdave
Copy link
Contributor

getdave commented Jan 9, 2020

let's explore this in a PR and then see what it feels like

@karmatosed @shaunandrews Just noting that there might be some overlap between this and #18310. Do we need to take account of that and/or update the designs?

@getdave getdave added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jan 9, 2020
@karmatosed
Copy link
Member Author

There absolutely is overlap, I think we can close out this issue and focus on the menu looking like the one that we have in #18310

@talldan talldan added [Block] Navigation Affects the Navigation Block and removed [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

No branches or pull requests

6 participants