Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading/Text block: editor toolbar "color" control #1955

Closed
lkraav opened this issue Jul 20, 2017 · 5 comments
Closed

Heading/Text block: editor toolbar "color" control #1955

lkraav opened this issue Jul 20, 2017 · 5 comments
Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@lkraav
Copy link

lkraav commented Jul 20, 2017

It should be possible to colorize a part of any text via the editor toolbar.

Lower priority, but perhaps also useful: API to define specific colors for user selection in the color picker - such as a selection of preset brand CVI colors.

@ellatrix
Copy link
Member

I realise this is quite a popular feature, colouring text and custom CSS, but I'm never sure if we should continue supporting this in Gutenberg (plugin territory).

An alternative is to let the theme register basic colour variables, so that they all change when you switch themes. They could also be overwritten by the user, for a specific theme, but fall back to the default when switching. Cc @hugobaeta @melchoyce.

See also: https://core.trac.wordpress.org/ticket/27159.

In any case, we should really do it right this time, if we add it. :)

@ellatrix ellatrix added Design [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement. labels Jul 24, 2017
@lkraav
Copy link
Author

lkraav commented Jul 24, 2017

I realise this is quite a popular feature, colouring text and custom CSS, but I'm never sure if we should continue supporting this in Gutenberg (plugin territory). An alternative is to let the theme register basic colour variables, so that they all change when you switch themes.

Plugins for everything is fine with me, but are regular folk really going to be happy to discover "Apparently I can't highlight a couple of words out of this headline with this modern new editor"? This is a basic technique for helping readers notice important stuff during scroll-through skimming.

@hugobaeta
Copy link

@lkraav

This is a basic technique for helping readers notice important stuff during scroll-through skimming.

I'd argue there are more semantic ways to markup something important in a text, namely strong (bold) and em for emphasis (italics). Colors have always been, in my opinion, a potentially dangerous tool to give a normal user. Especially because of how it's implemented, writing those values inline directly in the database. It creates scenarios where the text is set in a specific way that might look bad and create accessibility issues with a change of theme.

@iseulde I strongly believe Gutenberg is the clean slate we've longed for years, to guarantee the best, future-proof, accessible semantic experience out of the box. Everything else is plugin territory.

The theme-defined styles might be a great tool for theme designers and developers to use, beyond of this specific issue.

@lkraav
Copy link
Author

lkraav commented Jul 24, 2017

I'd argue there are more semantic ways to markup something important in a text, namely strong (bold) and em for emphasis (italics).

Yep, you're correct with this one and it's exactly what I'm converting my users towards.

@karmatosed
Copy link
Member

The paragraph tool not have coloring and I think for now that's enough. Let's close this and consider it a plugin for Gutenberg or something to consider as v2 of the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants