Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Block: Inserter color should always retain contrast to the background color #19690

Closed
apeatling opened this issue Jan 15, 2020 · 2 comments
Closed
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@apeatling
Copy link
Contributor

Describe the bug
When using a dark background color on the navigation block, the inserter becomes difficult to see:

Screen Shot 2020-01-15 at 3 28 03 PM

I think it should either always adjust itself to be a color that is high contrast to the selected background color, or match whatever the text color is.

To reproduce
Steps to reproduce the behavior:

  1. Add a navigation block with some items
  2. Set the background color to a darker color

Expected behavior
The inserter is always a color that is high contrast to the background color.

@apeatling apeatling added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Jan 15, 2020
@apeatling
Copy link
Contributor Author

Should be fixed by #18327

@karmatosed
Copy link
Member

This has now changed with recent iterations to a uniform '+'. For now, closing but we can always reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants