Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin menu collapses for 960px width but editor doesn't #19732

Closed
garretthyder opened this issue Jan 17, 2020 · 3 comments · Fixed by #19970
Closed

Admin menu collapses for 960px width but editor doesn't #19732

garretthyder opened this issue Jan 17, 2020 · 3 comments · Fixed by #19970
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@garretthyder
Copy link
Contributor

Describe the bug
This was originally noted by @JJJ on core Trac here - https://core.trac.wordpress.org/ticket/49212
After reproducing and investigating I found the issue lies in Gutenberg here;

@include editor-left(".edit-post-editor-regions");

*This mixing creates a min-width: 960px breakpoint, editing in inspect to 961px resolved the issue.

To reproduce
Steps to reproduce the behaviour:

  1. Install WP Trunk or Gutenberg latest plugin
  2. Navigate to the Editor
  3. Resize your browser to exactly 960px wide
  4. See white gap on the left.

Expected behavior
The editor and menu should respond together.

Screenshots
Screen Shot 2020-01-16 at 7 12 55 PM

Details

  • OS: macOS Catalina 10.15.2
  • Browser: Chrome 79.0.3945.117
  • WP: Trunk
@jorgefilipecosta jorgefilipecosta added the [Type] Bug An existing feature does not function as intended label Jan 23, 2020
@jorgefilipecosta
Copy link
Member

Hi @garretthyder, I'm not being able to reproduce this issue. Maybe it was resolved as a side effect of another change. Would it be possible to repeat the test on the last version of Gutenberg (or even better Gutenberg master) with the last version of WordPress trunk?

@garretthyder
Copy link
Contributor Author

Thanks for testing @jorgefilipecosta I just retested using WP trunk and Gutenberg master and was able to reproduce the issue. It is a little difficult to reproduce as it's only present at exactly 960px. At 956 or 961 the issue dissappears.
Myself I see the issue daily as I use Divvy to split my screen in two and 960px is exactly half so everytime I load the editor in half a screen the issue presents itself.

Let me know if you're still unable to reproduce.

@jorgefilipecosta
Copy link
Member

Thank you I think I was being affected by other parallel change. In my last test, I was able to reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants