Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary suggestion types in LinkControl #20051

Closed
Tracked by #35073
getdave opened this issue Feb 5, 2020 · 0 comments · Fixed by #36490
Closed
Tracked by #35073

Remove unnecessary suggestion types in LinkControl #20051

getdave opened this issue Feb 5, 2020 · 0 comments · Fixed by #36490
Assignees
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Feature] UI Components Impacts or related to the UI component system [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Feb 5, 2020

We should extract these types into a CONSTANT as it is used across the entire component.

Over time, I've begun to question whether we even need these. I feel like I may have left a similar comment recently elsewhere, but: For what purpose do we assign type for manually-entered URLs? It seems like a lot of extra work to assign and accommodate, when it may just be enough to assign nothing, and use the absence of a type as an indicator of a value being manually-entered.

isDirectEntry = ! value.type;

Edit: Not suggesting this be done as part of this pull request, but I would consider it as an alternative to a refactoring it.

Originally posted by @aduth in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzUzMTM3NTAx/pull_request_reviews/more_threads

@talldan talldan added [Feature] UI Components Impacts or related to the UI component system [Type] Code Quality Issues or PRs that relate to code quality labels Feb 7, 2020
@aduth aduth added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Apr 1, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Feature] UI Components Impacts or related to the UI component system [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants