Remove unnecessary suggestion
types in LinkControl
#20051
Labels
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
[Feature] UI Components
Impacts or related to the UI component system
[Status] In Progress
Tracking issues with work in progress
[Type] Code Quality
Issues or PRs that relate to code quality
Over time, I've begun to question whether we even need these. I feel like I may have left a similar comment recently elsewhere, but: For what purpose do we assign
type
for manually-entered URLs? It seems like a lot of extra work to assign and accommodate, when it may just be enough to assign nothing, and use the absence of a type as an indicator of a value being manually-entered.Edit: Not suggesting this be done as part of this pull request, but I would consider it as an alternative to a refactoring it.
Originally posted by @aduth in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzUzMTM3NTAx/pull_request_reviews/more_threads
The text was updated successfully, but these errors were encountered: