-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS overflow issue on editor post sidebar #20206
Comments
I can reproduce this issue on Firefox 73.0 (stable), whenever the sidebar is long enough to provoke a vertical scrollbar. Using latest development version of WP and latest Gutenberg. |
Adding this tentatively as a WP5.4 must have. I haven't quite been able to reproduce it, but judging from the info reported it seems like it may have been introduced recently. |
This issue seems hard to resolve, I tried lots of combinations of overflow-x, overflow-y, flex-grow, etc and ultimately I was not able to achieve to look we have in chrome. In firefox, it seems the width of the element is computed without the scroll bar y when the scrollbar y is needed the width does not recompute and as the scroll bar y takes some space, a need for scrollbar x appears (instead I think the browser should have recomputed the width of the element as chrome does). |
We did some refactorings a few releases back to centralize all the canvas CSS in the EditorSkeleton component. It's probably related. Maybe @jasmussen already encountered this and have ideas about it. |
Reproducible with The SEO Framework plugin. You may need to slide the postbox to the sidebar via the Classic Editor before loading Gutenberg to see it. The culprit is that the This should resolve the issue: .metabox-location-side .poststuff { min-width: unset } During live-edits via the developer console, you may want to resize the window to invoke repainting. Side note: I dislike the new padding/height of |
They recently renamed |
This fixes it: That is:
But the > div is ugly and likely some necessary fragment. And the top-fixed tabs break (CC: @epiqueras I think we discussed this recently). |
Yeah, I raised an issue about the tabs not being fixed consistently between mobile and desktop. |
@youknowriad I didn't follow the core change closely. I see the Trac ticket has been reopened because of some backwards compatibility concerns. Reference: Best person to ask @audrasjb I guess 🙂 |
This was fixed by #20355. |
🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉 |
this bug still exist. can confirm i have a scrollbar on full hd (1920x1080) because of multiple elements which are not border-box. please test multiple resolutions and devices before you mark bugs as completed! |
Bug is still there. |
This bug was previously reported downstream in trac, https://core.trac.wordpress.org/ticket/49405. I've copied that report here.
Describe the bug
This issue only appear on trunk version.
In the editor,the right sidebar content doesn't fit into its parent, and provokes a x-axis overflow (see attached screenshot).
Editor sidebar on trunk
Editor sidebar on 5.3.2
Adding some new details about the issue here:
I now notice the same behaviour on WordPress 5.4 beta 1.
It appears on Firefox Developer Edition 74.0beta.
The viewport is
width=device-width,initial-scale=1.0
.The text was updated successfully, but these errors were encountered: