Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading: notify about wrong level more clearly #20870

Open
mtias opened this issue Mar 13, 2020 · 2 comments · May be fixed by #22650
Open

Heading: notify about wrong level more clearly #20870

mtias opened this issue Mar 13, 2020 · 2 comments · May be fixed by #22650
Labels
[Block] Heading Affects the Headings Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@mtias
Copy link
Member

mtias commented Mar 13, 2020

Right now we are exposing this functionality in the document outline tool:
image

This is good, but I think we can also explore exposing this in the block itself:

image

It shouldn't be overtly dramatic, but hinting at something being off:

image

@mtias mtias added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Block] Heading Affects the Headings Block labels Mar 13, 2020
@karmatosed
Copy link
Member

I'm nodding as feel that is a great start. I would maybe consider the same treatment of a yellow background, or increasing the contrast on the coloring for headers (it feels like on the cusp of not being strong enough). I really like the idea of bringing awareness by the block itself.

@ZebulanStanphill
Copy link
Member

I'm definitely in favor of doing this. One thing to consider is how we can make this notification accessible. Changing the toolbar button tooltip probably isn't the right approach. Would it be possible to show a similar warning as the color contrast warning in the heading level dropdown?

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Mar 16, 2020
@ZebulanStanphill ZebulanStanphill linked a pull request Jul 16, 2020 that will close this issue
6 tasks
@ZebulanStanphill ZebulanStanphill linked a pull request Jul 16, 2020 that will close this issue
6 tasks
@ZebulanStanphill ZebulanStanphill removed the Needs Dev Ready for, and needs developer efforts label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants