Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip for PluginSlot / PluginSidebar inconsistent between browsers #21704

Closed
mattyrob opened this issue Apr 18, 2020 · 4 comments
Closed

Tooltip for PluginSlot / PluginSidebar inconsistent between browsers #21704

mattyrob opened this issue Apr 18, 2020 · 4 comments

Comments

@mattyrob
Copy link

mattyrob commented Apr 18, 2020

Describe the bug
If a new menu is created with a plugin a ToolTip is created with the menu title, the location of this ToolTip is below the menu icon in Chrome and Firefox but above the icon in Safari

To reproduce
Steps to reproduce the behavior:

  1. Create or use a plugin that adds a new PluginSidebar
  2. Visit the Block Editor in Safari, Chrome and FireFox
  3. In each browser hover the mouse over the menu icon.
  4. Note how the ToolTip is above the menu icon in Safari but below the icon in the other 2 browsers

Expected behavior
Tooltip location so be consistent across browsers

Screenshots
FireFox:
Screenshot 2020-04-18 at 13 57 20
Chrome:
Screenshot 2020-04-18 at 13 57 12
Safari:
Screenshot 2020-04-18 at 13 57 03

Editor version (please complete the following information):

  • WordPress version: 5.5-alpha-47585
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? "default"
    Desktop (please complete the following information):
  • OS: MacOS
  • Browser Safari 13.1, Chrome 81.0.4044.113, FireFox 75.0
  • Version [e.g. 22]
@mattyrob
Copy link
Author

I had change to install the Gutenberg plugin at version 7.9.1 and this issue appears to have resolved.

Leaving ticket here for review by core developer.

@talldan
Copy link
Contributor

talldan commented Apr 20, 2020

@mattyrob It looks like this is dynamic, so if there's space above the button within the window, the tooltip might go above, and if not, it might go below. I'm not sure if you might have had the editor in fullscreen mode in some instance, but that might explain the difference.

@talldan talldan closed this as completed Apr 20, 2020
@talldan
Copy link
Contributor

talldan commented Apr 20, 2020

I also just noticed the default was recently changed from above to below in #21476, so that explains why it now is resolved.

@mattyrob
Copy link
Author

Thanks @talldan , I was not using full screen and it seemed crowded when displayed above, so good to hear a fix is in the code now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants