Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display featured image (if set) as a thumbnail #2181

Closed
mtias opened this issue Aug 3, 2017 · 17 comments
Closed

Display featured image (if set) as a thumbnail #2181

mtias opened this issue Aug 3, 2017 · 17 comments
Labels
[Feature] Media Anything that impacts the experience of managing media General Interface Parts of the UI which don't fall neatly under other labels.

Comments

@mtias
Copy link
Member

mtias commented Aug 3, 2017

image

This would help in recognizing if a featured image is set for a post.

Implementation wise, we should look at moving away from local state in sidebar/featured-image and to push the image to redux state instead.

@mtias mtias added General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Media Anything that impacts the experience of managing media labels Aug 3, 2017
@StaggerLeee
Copy link

StaggerLeee commented Aug 3, 2017

Looks very nice. Finally my default no-featured.jpg wont stretch to be gigantic. As you planned before.
Maybe to move it to the left of the Title. It is most used case on Archive loops.

@karmatosed
Copy link
Member

More fuel for this:

From @helen:

I wish that the featured image showed as a block where the theme puts it, or maybe just always above the title. Not a side setting.

@StaggerLeee
Copy link

StaggerLeee commented Aug 3, 2017

Leave it in sidebar too. Not a big deal, as they are collapsed.

Developers tend to add HTML inside this metabox (sometimes per custom post type) to announce something to Editors. For instance sometimes featured image is used as Team member Photo, and wording is different, as it is the HTML description added to Metabox.

Sometimes developers add image size limit as HTML description, etc...

It cannot look nice with same HTML added in Gutenberg content area.

Here is a quick found list of few snippets used in Featured Image Metabox, that cannot be easy used in Gutenberg content area:

  • Add HTML to featured image metabox
  • Add a checkbox to the featured image metabox (example, Don’t display image on post view)
  • Add custom fields to featured Metabox
  • Change featured metabox header name
  • Change image size in Featured Metabox

If you an make it easy for developers to add all this under "Block" tab then problem is non existent.

@karmatosed karmatosed added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Aug 3, 2017
@helen
Copy link
Member

helen commented Aug 3, 2017

Isn't a featured image kind of like a pre-inserted immovable block of content rather than information about a post to be managed in a side setting? Actual theme usage varies but it's still much more content-esque than it's been treated. I imagine there's discussion about pre-defining a layout of blocks for people to fill out somewhere around here that has some parallels - #1684 looks like it might be that.

@StaggerLeee
Copy link

StaggerLeee commented Aug 3, 2017

It is Helen, by old WordPress matrix. Blogging, blogging, blogging.
WordPress today is much more than this.

Here are just few examples, from memory, where I used featured image that would be illogical as "content" block only:

  • Classifieds - No featured image will be inside content, from standard point of view.
  • Portfolio Archive with few custom links as image overlay - No Post detailed view.
  • Teams / Members - Featured image as (human) profile photo.
  • Gallery/Galleries Archive from Posts - Difficult to explain Archive thumbnail above Gallery in editor (backend). Or any place, it would not fit this purpose.
  • Custom ERP, Tasks management, Invoices, projects, organisations, clients. Not so easy to have Featured image for all those post types, inside Gutenberg content area.
  • Testimonies custom post type - Allways better to have person photo in sidebar than in content. My humble opinion.
  • WooCommerce Product Image.
  • Display of PDF thumbnails in template, Archives. Instead of ordinary ones. (They are inside Featured Image metabox)

Much more, more WP users, more versatile CMS cases. I mentioned only few I do.

@helen
Copy link
Member

helen commented Aug 3, 2017

Sorry, was thinking about single views and previews (since you can't really preview a change in non-single context) and didn't specify. I'm aware of varying custom usages of featured images.

@StaggerLeee
Copy link

Not sure if I understand all this technical talk.

I am just saying Featured Images is in many cases not something User should click somewhere to invoke it.
It needs to be visible on all post edit screen refresh/reload.

As you can see from very often used Team / Members custom post type. You can imagine Member face photo is crucial important to be visible all the time in post edit. As reference. No if, no click here, no context this or that. Just plain visible all the time.

You decided now to go with all sidebar tabs collapsed, but different story. Would be nice to remember open/close state, per User. Or it is generally step backward for Users. From previous drag & drop Metaboxes, remembering open/close state not they are forced to this.
On some news portals Excerpt sidebar tab, box is maybe of crucial importance and Editor want it open all the time. But, different story. No need to discuss it here. Maybe it is discussed here. #2194 I dont get it all right now.

@karmatosed karmatosed removed the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Aug 4, 2017
@hedgefield
Copy link

I second @helen's desire to have it moved it from the sidebar to the main content. There may be other usecases, but in general you'll want to use it as an image header above your post, so that's where it should be shown.

In the case of the mockup, I think I would prefer it on the left as well.

@mtias
Copy link
Member Author

mtias commented Apr 2, 2018

Moving to ideas.

@mtias mtias closed this as completed Apr 2, 2018
@adamsilverstein
Copy link
Member

What does 'moving to ideas' mean @mtias? Are we backlogging or tracking these 'idea' issues somewhere? This seems like a useful suggestion, can we leave the issue open?

@karmatosed
Copy link
Member

@adamsilverstein all ideas are kept here: https://github.com/WordPress/gutenberg/projects/8. We totally aren't losing or removing anything.

@adamsilverstein
Copy link
Member

@karmatosed Awesome, thanks for clarifying! I had no idea what putting something in Ideas meant :)

@alexmansfield
Copy link

For those of you who expressed interest in a featured image block that can be pre-inserted by a theme/plugin using Gutenberg templates, here is a simple plugin that does that: https://github.com/modularwp/gutenberg-block-featured-image

@kjellr
Copy link
Contributor

kjellr commented Jan 23, 2019

For those of you who expressed interest in a featured image block that can be pre-inserted by a theme/plugin using Gutenberg templates, here is a simple plugin that does that: https://github.com/modularwp/gutenberg-block-featured-image

Very cool. Here's a screenshot for reference:

screen shot 2019-01-23 at 9 39 26 am

Once page/post templates are represented a bit more visually in Gutenberg, I could see things working a bit like this: you'd select a post template that has a featured image, and then you'd have a position-locked featured image block you can edit.

@rodrigoslayertech
Copy link

Very cool. Here's a screenshot for reference:

screen shot 2019-01-23 at 9 39 26 am

Once page/post templates are represented a bit more visually in Gutenberg, I could see things working a bit like this: you'd select a post template that has a featured image, and then you'd have a position-locked featured image block you can edit.

"and then you'd have a position-locked featured image block you can edit"
How to do this?

@kjellr
Copy link
Contributor

kjellr commented Jan 28, 2019

How to do this?

It's not possible yet, but maybe something to explore in Phase 2 of Gutenberg.

@boemedia
Copy link

I like the fact that setting a featured image is now more visible to the content manager. However, not all themes require a featured image, so it may cause confusion. Maybe add a checkbox (as some themes do) by default, where people can disable the featured image? I also used to use a plugin where you could select an image in the post as featured image. This could maybe be a nice add-on to the image block: a selectbox to select an image in a post as a featured image too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

No branches or pull requests

10 participants