Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: LinkControl: Add label prop #22435

Closed
Tracked by #35073
aduth opened this issue May 18, 2020 · 0 comments · Fixed by #33849
Closed
Tracked by #35073

Block Editor: LinkControl: Add label prop #22435

aduth opened this issue May 18, 2020 · 0 comments · Fixed by #33849
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented May 18, 2020

Previously: #18061 (comment)

For consistency with other *Control components, LinkControl should be updated to support a label prop which, as with other input control components, can be used to customize the <label> rendering accompanying the form field. Also as with other input control components, this should ideally be implemented using BaseControl in order to leverage common behaviors and ensure consistency with other input control components.
@aduth aduth added [Type] Task Issues or PRs that have been broken down into an individual action to take [Package] Block editor /packages/block-editor [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels May 18, 2020
@aduth aduth mentioned this issue May 18, 2020
Closed
@youknowriad youknowriad mentioned this issue Jul 14, 2020
Merged
@adamziel adamziel mentioned this issue Jul 21, 2020
Closed
@fabiankaegy fabiankaegy mentioned this issue Sep 23, 2021
Open
39 tasks
@getdave getdave mentioned this issue Oct 20, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split control for URL and Text within Link UI WordPress/gutenberg
1 participant
@aduth