Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue up image edits to only apply once all edits are complete #22579

Closed
ajlende opened this issue May 23, 2020 · 2 comments
Closed

Queue up image edits to only apply once all edits are complete #22579

ajlende opened this issue May 23, 2020 · 2 comments
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media REST API Interaction Related to REST API

Comments

@ajlende
Copy link
Contributor

ajlende commented May 23, 2020

Follow-up from #21024 (comment)

Wondering what would be a good way to handle multiple actions all at once, so normal editing operations do not have to "edit" the image and add new files. (The old image editor in WP "stores" the actions in an array (which also allows for easy undo/redo) and generates only a temp preview image. The actual changes are applied to the original image on save).

Similarly to the crop view, we might have an 'edit' view. We could apply each change on the frontend using the image transformations from #22566. Queue up the effects and have an apply button or even maybe only apply the transformations when the draft is saved or published. I'm not sure if it would be easy or even possible to have everything apply on save, but I think that could make for a better user experience.

@ajlende ajlende added [Feature] Media Anything that impacts the experience of managing media REST API Interaction Related to REST API [Block] Image Affects the Image Block labels May 23, 2020
@ajlende ajlende added the Needs Design Needs design efforts. label Jun 2, 2020
@jasmussen
Copy link
Contributor

Here are some designs. I don't love that they become "layered" like this, but it seems a good way to start the conversation.

1

2

3

4

@jasmussen jasmussen removed the Needs Design Needs design efforts. label Jun 3, 2020
@ajlende ajlende mentioned this issue Jun 5, 2020
6 tasks
@ellatrix
Copy link
Member

Done in #23284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media REST API Interaction Related to REST API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants