Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview - [Feature] Navigation Screen #22931

Closed
13 of 15 tasks
draganescu opened this issue Jun 5, 2020 · 8 comments
Closed
13 of 15 tasks

Overview - [Feature] Navigation Screen #22931

draganescu opened this issue Jun 5, 2020 · 8 comments
Labels
[Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues
Milestone

Comments

@draganescu
Copy link
Contributor

draganescu commented Jun 5, 2020

This is an overview issue that we'll maintain going forward into WP 5.5 and 5.6 milestones. It attempts to track discussions and resulting actions about the new Navigation screen

This overview does not track bugs present in the new Navigation screen, for that you should filter open issues using the labels [Feature] Navigation Screen and [Type]Bug.

Block navigator

The block navigator is getting a lot of new features because of the requirements it has to solve in the new Navigation screen. Some of these updates are useful outside of this context as well, so they're considered also from the point of view of generic Gutenberg block editors (e.g. the Post editor).

Action items

Action items are things that need a PR for implementation or exploration.

Discussions

Discussions are general topics where we're less clear so we cannot start a PR to explore or implement.

Navigation block

The Navigation block has its own Overview issue (#22930), so this list is made if things that move the navigation screen forward in terms of UX, but most of the things here will also affect how the Navigator block works in other Gutenberg contexts (e.g. the post editor).

Action items

Action items are things that need a PR for implementation or exploration.

  • We need to add to drag and drop from the block itself (not the toolbar), at least in "selection" mode.
  • We should try to list the currently set link on the block toolbar for extra clarity [Navigation link block][Try] Show a URL next to the link icon #23023
  • Move automatically add top-level pages to ellipsis or somewhere else on the admin screen for navigation Start a pages block and move automatically add top-level pages to ellipsis or somewhere else #22749
  • Add a way to toggle the Navigation block between horizontal and vertical layouts (done via variation selector in the inspector)
  • We need to remove all the toolbar buttons of the Navigation block, including the styles selector, and keep the ellipsis.
  • We should find a way to display the inspector options in the new navigation screen for the blocks we select, especially if we’ll be allowing other kinds of blocks to be added to the Navigation block.
@draganescu draganescu added [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues [Feature] Navigation Screen labels Jun 5, 2020
@draganescu draganescu added this to the WordPress 5.x milestone Jun 5, 2020
@draganescu draganescu self-assigned this Jun 5, 2020
@ellatrix
Copy link
Member

Thanks for the overview issue. What is left for 5.5?

@draganescu
Copy link
Contributor Author

A lot! We're still missing a few key components: drag and drop in the block and in the sidebar, a couple of PRs that lag and are important for feature parity (#22600, #22697) and the ongoing work to support more block types in Navigation.

I believe we're in a place where a Gutenberg release after 5.5 will include this new screen, but maybe in the next two weeks some acceleration will occur and prove me wrong.

It is good that it's in "undecided" for now.

In any case I believe that it is wiser that this lands as a part of the plugin 1st, gets some feedback and then is shipped into core.

@TimothyBJacobs
Copy link
Member

@draganescu would the batch controller only be used by this screen? Or is it also needed for the nav block?

@draganescu
Copy link
Contributor Author

would the batch controller only be used by this screen? Or is it also needed for the nav block?

👋 The batch/bulk operations are useful for the navigation screen. For now the navigation block only reads from the list of menus and the list of menu items, writes nothing back.

@TimothyBJacobs
Copy link
Member

Thanks for clarifying @draganescu! I'm going to bump the batch controller out of the 5.5 milestone then.

@draganescu draganescu removed their assignment Nov 9, 2020
@annezazu annezazu mentioned this issue Feb 8, 2021
22 tasks
@draganescu
Copy link
Contributor Author

This overview issue is obsolete.

@annezazu
Copy link
Contributor

What's the best place to follow along at this point instead @draganescu :) Want to be sure I have the right links.

@draganescu
Copy link
Contributor Author

I am making an overview issue fot the Navigation screen which will be up to date with the evolution of that project,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues
Projects
None yet
Development

No branches or pull requests

4 participants