WP 5.5: merge all PHP changes #23210

ellatrix · 2020-06-16T16:30:23Z

With the WordPress 5.5 beta release around the corner, all PHP changes since Gutenberg v7.5 have to be merged with Core. Since we already want to merge Gutenberg 8.4 into core (updating the JS packages), this needs to be done as soon as possible, before 2020-06-24.

Update Packages GB 8.5 (JS): Update WordPress Packages wordpress-develop#347
Update Packages GB 8.5 (JS)

It looks like the following files have changed.

git diff release/7.5...master --name-only -- 'lib/' | sed 's/.*/[&](https:\/\/github.com\/WordPress\/gutenberg\/commits\/master\/&)/'

I collapsed some directories that contain one feature.

? = Undecided
x = Not for this release
A = Assigned

To know what changed in specific files, I use git diff release/7.5...master -- lib/compat.php for example.

The text was updated successfully, but these errors were encountered:

oandregal · 2020-06-16T16:44:35Z

Ella, I can help prepare a patch to bring in the changes related to lib/global-styles.php. There are some ongoing conversations that may affect which parts are ported and/or how, but I'll figure it out.

ellatrix · 2020-06-16T16:44:58Z

@nosolosw Thanks!

ellatrix · 2020-06-16T19:22:12Z

Found a neat trick to collapse also there file types that's not available in the Github UI: https://github.com/WordPress/gutenberg/compare/release%2F7.5...master?file-filters%5B%5D=.php

It's still a huge page that has problems loading though.

gziolo · 2020-06-17T05:54:50Z

The good news is that packages/block-library/* is automatically synced with the build process in WordPress core. We can also skip everything in packages/e2e-tests/*. In addition to that bin/get-server-blocks.php was for internal usage and it was removed.

I plan to backport:

phpunit/class-register-block-type-from-metadata-test.php
phpunit/fixtures/block.asset.php
related parts to that in lib/compat.php

draganescu · 2020-06-17T13:57:14Z

@TimothyBJacobs @spacedmonkey Just to note in this thread, are you aiming at bringing the menu endpoints into core for 5.5, because if so the files in that update these will be handled by one of you in a patch right? (This is just something in my memory but I could be completely wrong)

TimothyBJacobs · 2020-06-17T14:26:40Z

are you aiming at bringing the menu endpoints into core for 5.5

Will any of the Gutenberg features utilizing the endpoints be shipping in 5.5? If so, yep that's my plan.

the files in that update these will be handled by one of you in a patch right

Yeah we have a tracking ticket for it on Core and will make sure they get merged.

gziolo · 2020-06-17T14:38:29Z

There is a Trac ticket for block types REST API endpoint, but it as well rather depends on whether we integrate it with the codebase.

I'll be looking into backporting register_block_type_from_metadata next week.

TimothyBJacobs · 2020-06-17T14:54:52Z

I might ship the block types endpoint regardless, since we're dropping the individual block renderer endpoints there wouldn't otherwise be a way to get those attributes.

That being said, I'd be infinitely more comfortable if Gutenberg was using it.

ellatrix · 2020-06-17T18:25:14Z

The good news is that packages/block-library/* is automatically synced with the build process in WordPress core.

Is there any documentation around that?

youknowriad · 2020-06-17T20:13:09Z

Is there any documentation around that?

AFAIK, no documentation but it's just a copy script that happens on npm install (or build)

spacedmonkey · 2020-06-17T21:30:02Z

I have a PR for menus endpoint and block types
Menus endpoint - WordPress/wordpress-develop#319
Block Type endpoint - WordPress/wordpress-develop#317

draganescu · 2020-06-18T05:59:55Z

Hi @TimothyBJacobs ,

Will any of the Gutenberg features utilizing the endpoints be shipping in 5.5? If so, yep that's my plan.

It likely that the Navigation page won't make it but the Navigation block does use the endpoints to "create from existing". On the other hand I don't know if the block will be out of experimental by that time.

My question was mostly related to @spacedmonkey 's effort above :)

oandregal · 2020-06-18T10:42:55Z

Ella, I've got clarity about some global styles related things, and we're not shipping them in 5.5, I've crossed out a couple of files we don't need (lib/global-styles.php and lib/editor-features.php).

I've also audited lib/client-assets.php for the things I'm familiar with and the function gutenberg_extend_settings_link_color shouldn't be ported to core either (I don't know how you prefer to mark this in the ticket, so I didn't).

spacedmonkey · 2020-06-18T10:49:39Z

We also need to port this - #22721

TimothyBJacobs · 2020-06-18T15:06:15Z

On the other hand I don't know if the block will be out of experimental by that time.

Do we know when a decision will be made on that? We really need first party usage before including the nav endpoints in Core.

ockham · 2020-06-18T16:48:47Z

I added some fields to the /themes endpoint in #21578. Those have been backported to Core already, but ended up in a slightly different format. So this change doesn't need backporting to Core, but I'll update Gutenberg to reflect that format, and add some kind of version check so it doesn't add those fields if they're already provided by Core.

Sound about right @TimothyBJacobs ? 😊

TimothyBJacobs · 2020-06-18T16:50:19Z

I added some fields to the /themes endpoint in #21578. Those have been backported to Core already, but ended up in a slightly different format. So this change doesn't need backporting to Core, but I'll update Gutenberg to reflect that format, and add some kind of version check so it doesn't add those fields if they're already provided by Core.

Sound about right @TimothyBJacobs ? 😊

Yep! See also #23054.

noisysocks · 2020-06-22T01:52:49Z

It likely that the Navigation page won't make it but the Navigation block does use the endpoints to "create from existing". On the other hand I don't know if the block will be out of experimental by that time.

I think that it (still) doesn't make sense to ship the Navigation block without also shipping either FSE or the Navigation screen. The block isn't very useful inside posts or pages.

ockham · 2020-06-22T09:25:13Z

I added some fields to the /themes endpoint in #21578. Those have been backported to Core already, but ended up in a slightly different format. So this change doesn't need backporting to Core, but I'll update Gutenberg to reflect that format, and add some kind of version check so it doesn't add those fields if they're already provided by Core.
Sound about right @TimothyBJacobs ? blush

Yep! See also #23054.

PR: #23321

ellatrix · 2020-06-22T10:57:18Z

@noisysocks The navigation block shouldn't be included this release.

ellatrix · 2020-06-22T11:01:31Z

@spacedmonkey @TimothyBJacobs If a REST API endpoint will not be used by anything, there's probably no point in adding it to core. On the contrary, maybe it does more damage as we won't be able to change it if it isn't experimental.

TimothyBJacobs · 2020-06-22T11:16:15Z

@spacedmonkey @TimothyBJacobs If a REST API endpoint will not be used by anything, there's probably no point in adding it to core. On the contrary, maybe it does more damage as we won't be able to change it if it isn't experimental.

Agreed. The menus route is no longer in the milestone.

ellatrix · 2020-06-22T11:56:17Z

@TimothyBJacobs Is the block types endpoint still something that should be merged?

TimothyBJacobs · 2020-06-22T11:59:54Z

@TimothyBJacobs Is the block types endpoint still something that should be merged?

I’d prefer to see it being used to bootstrap the editor, I believe @gziolo is looking at that?

But I think it is important to land regardless since the individual block renderer endpoints, and their accompanying attribute schemas, have been dropped in 5.5.

I’m less worried about block types since it is pretty much a direct output of the block registration RFC which as I understand it has been stabilized.

gziolo · 2020-06-22T14:55:57Z

There is still some time left to work on integration with the block types endpoint. It’s very solid and follows the RFC fully. If we missed anything we can fix it during the release process. I want us to have at least a proof of concept that validates integration with the block registration on the client.

gziolo · 2020-06-23T16:18:35Z

register_block_type_from_metadata is now backported together with tests ( from lib/compat.php) – https://core.trac.wordpress.org/ticket/50263.
PR for WP_Block and tests is opened at Editor: Introduce WP_Block and WP_Block_List classes wordpress-develop#351.

We still need to check what was added to lib/compat.php and decide whether it needs to be backported.

tellyworth · 2020-06-26T05:18:30Z

The enqueue code from lib/block-directory.php is backported in WordPress/wordpress-develop#359.
The data-handle part from that is going into a patch on https://core.trac.wordpress.org/ticket/48654. I think it's safe for that to be done separately, since there's nothing that currently depends on that filter as far as I'm aware.

youknowriad · 2020-07-09T08:21:27Z

This is done right? Closing, let me know if we should reopen

ellatrix added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jun 16, 2020

ellatrix added this to the Gutenberg 8.4 milestone Jun 16, 2020

ellatrix added the [Priority] High Used to indicate top priority items that need quick attention label Jun 16, 2020

noisysocks modified the milestones: Gutenberg 8.4, Gutenberg 8.5 Jun 22, 2020

ellatrix removed this from the Gutenberg 8.5 milestone Jun 22, 2020

mcsf mentioned this issue Jun 24, 2020

Block categories: Inconsistent legacy mappings #23118

Closed

youknowriad closed this as completed Jul 9, 2020

This was referenced Jul 15, 2020

Dev Notes for WP 5.5 #23669

Closed

Add link color component #22722

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WP 5.5: merge all PHP changes #23210

WP 5.5: merge all PHP changes #23210

ellatrix commented Jun 16, 2020 •

edited by TimothyBJacobs

Loading

oandregal commented Jun 16, 2020

ellatrix commented Jun 16, 2020

ellatrix commented Jun 16, 2020 •

edited

Loading

gziolo commented Jun 17, 2020

draganescu commented Jun 17, 2020 •

edited

Loading

TimothyBJacobs commented Jun 17, 2020

gziolo commented Jun 17, 2020

TimothyBJacobs commented Jun 17, 2020

ellatrix commented Jun 17, 2020

youknowriad commented Jun 17, 2020

spacedmonkey commented Jun 17, 2020

draganescu commented Jun 18, 2020 •

edited

Loading

oandregal commented Jun 18, 2020 •

edited

Loading

spacedmonkey commented Jun 18, 2020

TimothyBJacobs commented Jun 18, 2020

ockham commented Jun 18, 2020

TimothyBJacobs commented Jun 18, 2020

noisysocks commented Jun 22, 2020

ockham commented Jun 22, 2020

ellatrix commented Jun 22, 2020

ellatrix commented Jun 22, 2020

TimothyBJacobs commented Jun 22, 2020

ellatrix commented Jun 22, 2020

TimothyBJacobs commented Jun 22, 2020

gziolo commented Jun 22, 2020

gziolo commented Jun 23, 2020 •

edited

Loading

tellyworth commented Jun 26, 2020

youknowriad commented Jul 9, 2020

WP 5.5: merge all PHP changes #23210

WP 5.5: merge all PHP changes #23210

Comments

ellatrix commented Jun 16, 2020 • edited by TimothyBJacobs Loading

oandregal commented Jun 16, 2020

ellatrix commented Jun 16, 2020

ellatrix commented Jun 16, 2020 • edited Loading

gziolo commented Jun 17, 2020

draganescu commented Jun 17, 2020 • edited Loading

TimothyBJacobs commented Jun 17, 2020

gziolo commented Jun 17, 2020

TimothyBJacobs commented Jun 17, 2020

ellatrix commented Jun 17, 2020

youknowriad commented Jun 17, 2020

spacedmonkey commented Jun 17, 2020

draganescu commented Jun 18, 2020 • edited Loading

oandregal commented Jun 18, 2020 • edited Loading

spacedmonkey commented Jun 18, 2020

TimothyBJacobs commented Jun 18, 2020

ockham commented Jun 18, 2020

TimothyBJacobs commented Jun 18, 2020

noisysocks commented Jun 22, 2020

ockham commented Jun 22, 2020

ellatrix commented Jun 22, 2020

ellatrix commented Jun 22, 2020

TimothyBJacobs commented Jun 22, 2020

ellatrix commented Jun 22, 2020

TimothyBJacobs commented Jun 22, 2020

gziolo commented Jun 22, 2020

gziolo commented Jun 23, 2020 • edited Loading

tellyworth commented Jun 26, 2020

youknowriad commented Jul 9, 2020

ellatrix commented Jun 16, 2020 •

edited by TimothyBJacobs

Loading

ellatrix commented Jun 16, 2020 •

edited

Loading

draganescu commented Jun 17, 2020 •

edited

Loading

draganescu commented Jun 18, 2020 •

edited

Loading

oandregal commented Jun 18, 2020 •

edited

Loading

gziolo commented Jun 23, 2020 •

edited

Loading