Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: Restore aria-expanded on the button #24036

Closed
afercia opened this issue Jul 19, 2020 · 0 comments · Fixed by #24046
Closed

Panel: Restore aria-expanded on the button #24036

afercia opened this issue Jul 19, 2020 · 0 comments · Fixed by #24046
Assignees
@diegohaz
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Jul 19, 2020

Describe the bug

In #23327 the Panel component went through some refactoring. Amongst other things, the aria-expanded attribute was removed from the Panel button.

Now, all the panels in the editor don't give any clue to assistive technology users whether they're collapsed or expanded.

The aria-expanded attribute is of fundamental importance not only to communicate the Panel state but also to let users understand how they have to interact with it.

To reproduce

  • test with the plugin version 8.5.1
  • inspect the sidebar panels HTML in your browser's dev tools
  • observe the panel buttons don't have an aria-expanded attribute any longer
  • use a screen reader, navigate to the panel buttons and observe the collapsed / expanded state of the panels is not announced
@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release [Package] Components /packages/components labels Jul 19, 2020
@diegohaz diegohaz mentioned this issue Jul 20, 2020
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 20, 2020
@ItsJonQ ItsJonQ mentioned this issue Jul 20, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegohaz diegohaz

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Components: Add aria-expanded back to Panel WordPress/gutenberg
2 participants
@afercia @diegohaz