-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of List View drag and drop #25067
Comments
Hi All, |
With the Gutenberg plugin installed. Then in the Navigation screen click the black inserter + icon to add a block. In the Navigation structure or in the Navigation menu. I just clicked the + icon a bunch of times to insert empty links. I am not able to drag and drop though. I can use the up and down arrows. |
Hey @talldan, is this issue in your near future plans, or is it available to pick? |
It can be picked up, not something that I plan on looking at soon. Though, I did have a quick look at it recently but without success. I have a feeling a nice optimisation might be to switch to using an absolutely positioned separate element for the insertion point indicator, a bit like how the main block editor does now. Currently dragging over the blocks updates each block to show a border to indicate where the block will drop and this seems quite slow. |
Managed to get around to this now that widgets work has slowed down. #33320 is the PR. |
Describe the bug
The performance for drag and drop in List View (currently enabled on the experimental navigation page) deteriorates significantly in relation to the number of blocks present, in contrast to the general editor canvas.
I've noticed a few things that can be improved. A big on seems to be that
useDropZone
is continuallyTo reproduce
Steps to reproduce the behavior:
Expected behavior
Observe the updates to the drop zones and draggable chip become very laggy.
The text was updated successfully, but these errors were encountered: