Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using transient attributes on global styles entity #25138

Closed
oandregal opened this issue Sep 8, 2020 · 2 comments
Closed

Try using transient attributes on global styles entity #25138

oandregal opened this issue Sep 8, 2020 · 2 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@oandregal
Copy link
Member

Follow-up #24250 (comment)

The idea would be that we store the transient edits as objects within the entity, so we don't have to serialize/deserialize from a string, which is how it's stored in the CPT.
@oandregal oandregal added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Sep 8, 2020
@oandregal oandregal mentioned this issue Sep 8, 2020
Merged
@oandregal oandregal changed the title Try using transient attributes on global styles CPT Try using transient attributes on global styles entity Sep 8, 2020
@jorgefilipecosta jorgefilipecosta mentioned this issue Nov 24, 2020
Closed
82 tasks
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 17, 2023
@jordesign
Copy link
Contributor

@oandregal @jorgefilipecosta Just looping back through some inactive issues - just wanted to see if this is still a task/enhancement that needs follow through?

@oandregal
Copy link
Member Author

This API has changed quite a bit, so this can be safely closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oandregal @jordesign