-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove link by deleting value of URL #25414
Comments
Thank you for labelling this, @youknowriad. Just to add context on this issue, and why I believe it is more than just an enhancement, if the block being edited is at the very bottom of the viewport (which can be a fairly common scenario) the block toolbar will be obscured by the URL box, making it effectively impossible for the user to remove the link: |
I realize that, given the additional context, it might be a good idea to rename the issue. |
Related: #18866 |
This issue is now largely solved by the The trouble with allowing a user to delete and then submit "empty" to remove is that it's ambigious. In most cases we don't want the user to submit empty content as that could create an empty link. Indeed I'm working on a fix right now that disables such behaviour. @mrfoxtalbot Would you say this is a big issue now the |
Thank you @getdave! Yes, I think that the new "Unlink" button pretty much solves this. I am closing this now. |
Describe the bug
When trying to remove a link, emptying the placeholder/value of the URL in the link should work.
To reproduce
Steps to reproduce the behavior:
Expected behavior
The editor will prompt the user to add a "Please fill in this field". I would expect that submitting an empty value on a link would remove the link.
Screenshots
Editor version (please complete the following information):
Desktop (please complete the following information):
Additional context
I have found several people struggling to remove a link, expecting that removing the URL would just remove the link.
The text was updated successfully, but these errors were encountered: