Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Actions: Use page name for document title #25546

Closed
noahtallen opened this issue Sep 22, 2020 · 12 comments
Closed

Document Actions: Use page name for document title #25546

noahtallen opened this issue Sep 22, 2020 · 12 comments
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@noahtallen
Copy link
Member

In the site editor, we should use the page name as a document title if the context exists for a page.

TBD: exactly when should we use the page name?

cc @shaunandrews

@noahtallen
Copy link
Member Author

This is a pretty easy change to make. Basically, you just add something like:

const documentTitle = page?.type === 'page' ? page.label : template?.slug;

to the header component and pass it into the document actions component.

Anyways, I tried that. Here's what it looks like:

2020-09-22 15 04 41

I found it a bit weird:

  • I think users will wonder "what does index mean?" when they don't have the page selected. (In this case, it's just the template that the homepage defaults to. The homepage is set to show all posts.)
  • it's not really obvious to me that "sample page" is the title. I'd think it might need to stand out a little more. I bet adding more settings here would be helpful
  • intermixing template and page titles feels a bit off for some reason

@noahtallen
Copy link
Member Author

noahtallen commented Sep 22, 2020

To clarify this:

page?.type === 'page'

In the site editor, we have a data structure we're calling a "page" to represent actual webpages of the site you might navigate to IRL. So the page could be something like a post, or a page page or an archive page, or a category page, or something like that. It's basically just a representation so that we can load the correct context for the page in the editor.

@paaljoachim
Copy link
Contributor

Gutenberg.
Here I have removed the page title "Contact" from the content area and added the page title to the top bar.
Page-title-top-bar

As there is no default page title in the content the placeholder begins further up where the earlier page title was located.
Instead there is a page/post title block the user can add to get the title back into the content area.

In Full Site Editing.
Default looks like this:
Screen Shot 2020-09-23 at 17 15 17

The top bar shows the current selected page "Contact" and then the / index. The mixing of page title and template name seems out of place (as you mentioned).

The above screens should be identical as FSE and Gutenberg will be mixed together.

Modifying the FSE mode.
FSE-Page-title-top-bar

In the above the focus is still the page "Contact" and page content.
Moving from page content to template needs a little more hidden approach then what we see with the Contact / Index (which is confusing).

As this is kinda like working with widget areas. One leaves the page content goes to the widget screen and adds content to the header, sidebar and footer widget areas. It is another process.

Some brain storming....

I am working on the page content and want to see which "widget areas" are associated with it. The sidebar settings when nothing is selected should show information about "widget areas". One should then also be able to go into a full site mode. One could also add an overview mode beside the page/post title. It needs to be a clear and easy to understand name.

FSE-Overview

As one could easily switch between Overview mode and direct page content mode, by clicking Overview or Contact.


Going back to the beginning. Perhaps we should see this:
Page-Content-Overview

Another name for it.
Site-content-page

Bottom line:
Should there be an overview text link mode next to the page/post title? Or should there instead be an icon/button to click? Going from content mode to full page mode. There should be a simple way to switch between the two modes.

Associated issue:
(Moving page/post title to the top bar + adding a page/post title block.)
#22621

(Working in Full Site Editing one sees the selected Template name in the top.)
#25320

@noahtallen
Copy link
Member Author

As this is kinda like working with widget areas. One leaves the page content goes to the widget screen and adds content to the header, sidebar and footer widget areas. It is another process.

Interesting! I'm not really familiar with widget screens at the moment. I've been thinking about it more as editing the template part (e.g. header or footer) inline within the site editor without leaving.

Going from content mode to full page mode. There should be a simple way to switch between the two modes.

I honestly don't know much about how this should work :D I don't know of many explorations around how that kind of mode switching would work -- currently, you are able to edit post content inline in the site editor ok, but there isn't a way to "zoom in" and only look at the page content.

Should there be an overview text link mode next to the page/post title? Or should there instead be an icon/button to click

I think this is very similar to some of the ideas in this sort of design, where you have a chevron icon which opens a menu/modal. That menu/modal contains settings:

image

In your mind, what would an overview thing do?

@paaljoachim
Copy link
Contributor

If we take a step back in time. The the regular way to add content to a header, sidebar or footer would be to go to the widget screen or the customizer and widgets and add in some content. Preview in customizer or frontend.

Older version of the Widget screen. Containing various site content areas:
Screen Shot 2020-09-23 at 23 01 50

Will Full Site Editing we are in a sense making the widget screen obsolete. As how we earlier added information to these areas are being added to Full Site Editing. We are updating the widget experience and making adding content to the header, sidebar and footer etc a lot easier and more direct by doing so through Full Site Editing.

--

Overview = zoom out showing site content areas. Header, sidebars, footer etc.
Page title = zoom back in to the page content.

It should be easy and straight forward to zoom in to page content and zoom out to site content.
The question is what information should be obvious for the user?
The primary should be how to go between the zoom in and zoom out modes. Go modify page content in zoom in mode and to modify site content and areas in zoom out mode.

@noahtallen
Copy link
Member Author

Yeah, I feel like I've heard that idea discussed before. I can't find any existing issues for it though, so i wonder if it makes sense to split that out separately?

IMO, considering the page name in the top bar could be added either way

@paaljoachim
Copy link
Contributor

I can go ahead and create a new issue (if I can not find an existing issue) for the comment I made above in relation to switching between page content and site content.

@noahtallen
Copy link
Member Author

Thinking about the page title again, we generate this page information for the page selector:

Screen Shot 2020-09-23 at 4 29 29 PM

In this case, "page" refers to a page of your website, not the page CPT.

The label in the topbar should probably match those labels too. If you are navigating FSE using these kinds of options, the top item should match the item you choose as you navigate around.

@dubielzyk
Copy link

I really like that idea. If the users intent is to edit a page we should show the page name like you have outlined there @noahtallen. I also think we'll need to show the name "Homepage" for whatever is selected as homepage. Showing All posts may not make sense to most users.

If a user shows intent to edit a template, we'd show the template name.

@paaljoachim
Copy link
Contributor

I went ahead and added a comment here:
#20877 (comment)
and here: #25085 (comment)
Instead of opening a new issue as it feels like my comment is a part of multiple issues.

In relation to switching between page/post (zoomed in view) <-> site (zoomed out view) as well as what happens when selecting the header area.
I made a prototype in figma:
https://www.figma.com/proto/utLW746LHQ9dXy2oHvwttM/FSE-UX-flow?node-id=1%3A4&scaling=min-zoom

@noahtallen
Copy link
Member Author

ok! Yeah, no worries. I suggested it, because this is the first time I'm hearing us discuss adding a "zoom in/out" sort of mode like this in FSE. So I wonder if it is something that needs to be more widely discussed -- because we'll be trying the basic info and settings in the header regardless of adding a zoom mode

@noahtallen noahtallen removed their assignment Dec 9, 2020
@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@youknowriad
Copy link
Contributor

Now that we have the "template and page" modes in the site editor with a well designed title bar. I think this is largely addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants