-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Actions: Use page name for document title #25546
Comments
This is a pretty easy change to make. Basically, you just add something like: const documentTitle = page?.type === 'page' ? page.label : template?.slug; to the header component and pass it into the document actions component. Anyways, I tried that. Here's what it looks like: I found it a bit weird:
|
To clarify this:
In the site editor, we have a data structure we're calling a "page" to represent actual webpages of the site you might navigate to IRL. So the page could be something like a post, or a page page or an archive page, or a category page, or something like that. It's basically just a representation so that we can load the correct context for the page in the editor. |
Gutenberg. As there is no default page title in the content the placeholder begins further up where the earlier page title was located. In Full Site Editing. The top bar shows the current selected page "Contact" and then the / index. The mixing of page title and template name seems out of place (as you mentioned). The above screens should be identical as FSE and Gutenberg will be mixed together. In the above the focus is still the page "Contact" and page content. As this is kinda like working with widget areas. One leaves the page content goes to the widget screen and adds content to the header, sidebar and footer widget areas. It is another process. Some brain storming.... I am working on the page content and want to see which "widget areas" are associated with it. The sidebar settings when nothing is selected should show information about "widget areas". One should then also be able to go into a full site mode. One could also add an overview mode beside the page/post title. It needs to be a clear and easy to understand name. As one could easily switch between Overview mode and direct page content mode, by clicking Overview or Contact. Going back to the beginning. Perhaps we should see this: Bottom line: Associated issue: (Working in Full Site Editing one sees the selected Template name in the top.) |
Interesting! I'm not really familiar with widget screens at the moment. I've been thinking about it more as editing the template part (e.g. header or footer) inline within the site editor without leaving.
I honestly don't know much about how this should work :D I don't know of many explorations around how that kind of mode switching would work -- currently, you are able to edit post content inline in the site editor ok, but there isn't a way to "zoom in" and only look at the page content.
I think this is very similar to some of the ideas in this sort of design, where you have a chevron icon which opens a menu/modal. That menu/modal contains settings: In your mind, what would an overview thing do? |
Yeah, I feel like I've heard that idea discussed before. I can't find any existing issues for it though, so i wonder if it makes sense to split that out separately? IMO, considering the page name in the top bar could be added either way |
I can go ahead and create a new issue (if I can not find an existing issue) for the comment I made above in relation to switching between page content and site content. |
Thinking about the page title again, we generate this page information for the page selector: In this case, "page" refers to a page of your website, not the page CPT. The label in the topbar should probably match those labels too. If you are navigating FSE using these kinds of options, the top item should match the item you choose as you navigate around. |
I really like that idea. If the users intent is to edit a page we should show the page name like you have outlined there @noahtallen. I also think we'll need to show the name "Homepage" for whatever is selected as homepage. Showing All posts may not make sense to most users. If a user shows intent to edit a template, we'd show the template name. |
I went ahead and added a comment here: In relation to switching between page/post (zoomed in view) <-> site (zoomed out view) as well as what happens when selecting the header area. |
ok! Yeah, no worries. I suggested it, because this is the first time I'm hearing us discuss adding a "zoom in/out" sort of mode like this in FSE. So I wonder if it is something that needs to be more widely discussed -- because we'll be trying the basic info and settings in the header regardless of adding a zoom mode |
Now that we have the "template and page" modes in the site editor with a well designed title bar. I think this is largely addressed. |
In the site editor, we should use the page name as a document title if the context exists for a page.
TBD: exactly when should we use the page name?
cc @shaunandrews
The text was updated successfully, but these errors were encountered: