-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Author selector: use native <select>
element for a small number of authors.
#26077
Comments
@youknowriad when working on this I have noticed that chrome tries to autofill the input field which interferes visually with the search feature of the ComboboxControl: I think we can fix that by adding |
yes, it makes sense 👍 |
Will address in a separate PR. |
@youknowriad Took a pass at addressing this in #26426 - the code is slightly complicated by the fact that we need to make sure we don't display a select when the combobox result count falls below the threshold. |
@youknowriad I addressed the autocomplete issue in #26427. |
Is your feature request related to a problem? Please describe.
In #23237 we improved the post author selector by adding an accessible autocomplete searchable selector, building on the
<ComboboxControl>
component. This works especially well for a large number of possible authors when a select becomes unwieldy.On the other hand, when a site has only a small number of potential post authors, a native select element similar to what we had previously would be better for users: simpler, even more consistently accessible, and faster. Worth noting that when sites have only one author, we don't show the selector at all.
Describe the solution you'd like
First: pick the number of users we want have be the "cutoff" when we start using the searchable select element vs the simpler native select element? Is it when we have 20 users, or 50 or more? Some design feedback would be useful here, and ideally some user studies, accessibility guidelines or other data. I couldn't find much in my brief search.
For sites that have [CUTOFF] or fewer fewer potential authors, show the same
select
element we were showing previously. Only show the newComboboxControl
when sites have more than [CUTOFF] authors.As mentioned in #23237 (comment), #25267 (comment).
Questions
Should [CUTOFF] be developer controllable, and if so, how?
The text was updated successfully, but these errors were encountered: