Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix and suffix handling in template tag blocks #26393

Closed
jameskoster opened this issue Oct 22, 2020 · 2 comments
Closed

Prefix and suffix handling in template tag blocks #26393

jameskoster opened this issue Oct 22, 2020 · 2 comments

Comments

@jameskoster
Copy link
Contributor

A consistent pattern for handling the manipulation of plain text around the data in blocks like the Post Categories, Post Tags, Post Comments Count, etc is looking like something we might need for theme development.

Let's look at Post Tags for an example. Inserting this block will display all the post tags on the Canvas like so:

Now lets zoom in on the design of the Post template in Twenty Twentyone:

Here we see a need to add a "Tagged" prefix/label on this block.

What we have now

The Post Author block currently includes an affordance similar to this, for adding a byline:

1

It's a little clunky to use (things jump around when you select the block), and perhaps too opinionated in terms of design (what if I want the byline below the username?).

Since so many of these blocks will require this functionality – see "Categorized as" in the twentytwentyone screenshot above for another example – it might be beneficial to design a consistent pattern that can be used by all.

It should be noted that there is a delicate balance to be struck here between giving folks an acceptable level of control, whilst avoiding the need to create innerblocks.

@jameskoster
Copy link
Contributor Author

Possibly a duplicate of #25448 🙈

@annezazu
Copy link
Contributor

Agreed that #25448 seems similar enough for this to be considered a duplicate :D Mind commenting with your feedback there to consolidate? Going to close this out for now unless you think it's different enough that it should remain open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants