Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent page dropdown: screen reader issues #27385

Closed
tellthemachines opened this issue Dec 1, 2020 · 2 comments · Fixed by #27431
Closed

Parent page dropdown: screen reader issues #27385

tellthemachines opened this issue Dec 1, 2020 · 2 comments · Fixed by #27431
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@tellthemachines
Copy link
Contributor

Describe the bug

When navigating to the parent page dropdown under "Page Attributes" in the sidebar, VoiceOver on Safari does not announce the input label, but goes straight to announcing number of options.

Additionally, if a selection already exists, it is not announced either with VoiceOver/Safari or with NVDA/Firefox, so the user has no way of knowing if an option is currently selected.

To reproduce
Steps to reproduce the behavior:

  1. Go to any page (there must be multiple pages on the website);
  2. Using VoiceOver, navigate to Page Attributes in the sidebar, then tab once to land in the parent page dropdown;
  3. Verify that VoiceOver doesn't announce the component name (which is "Parent page);
  4. Select an option from the dropdown;
  5. Tab away from the dropdown, and then tab back into it;
  6. Verify that the previously selected option is not announced.

Expected behavior

Expected both component label, and existing selection (if there is one), to be read out by screen reader when focusing on the input.

Editor version (please complete the following information):

  • WordPress version: 5.6 RC1
  • If the Gutenberg plugin is installed, which version is it? 9.4.1
@tellthemachines tellthemachines added [a11y] Labelling [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Dec 1, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 2, 2020
@alexstine
Copy link
Contributor

@tellthemachines I tried testing using Windows NV Access and Mac Voiceover and never had a problem while tabbing to the "Page Parent" combo box. It announced the label as well as the currently selected value. I am still on Mac Catalina as the newer version Mac Big Sur had some rather interesting Voiceover bugs. This was before testing your pull request. Thanks.

@alexstine
Copy link
Contributor

This was my mistake in testing. Here is my updated view: #27431 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants