Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block API: Allow blocks to specify attributes that map to site options #2759

Closed
aduth opened this issue Sep 20, 2017 · 2 comments
Closed

Block API: Allow blocks to specify attributes that map to site options #2759

aduth opened this issue Sep 20, 2017 · 2 comments
Labels
[Feature] Block API API that allows to express the block paradigm. [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
Future

Comments

@aduth
Copy link
Member

aduth commented Sep 20, 2017 •
edited
Loading

Related: #2754

At the moment a block's attributes can come from two places: sourced from HTML, or serialized as JSON in HTML comments.

Edit: As of #2740, it is also possible to source attributes from post meta (see documentation)

We want to allow attributes that can be retrieved and saved as site options. Such attributes won't exist in the HTML, meaning they rely on server rendering through get_option().
@aduth aduth added [Feature] Block API API that allows to express the block paradigm. [Type] Task Issues or PRs that have been broken down into an individual action to take labels Sep 20, 2017
This was referenced Sep 20, 2017
Closed
Merged
@aduth aduth mentioned this issue Oct 23, 2017
Closed
@jeffpaul
Copy link
Member

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@jeffpaul jeffpaul added this to the Bonus Features milestone Feb 22, 2018
@mtias mtias added the Future label Jul 12, 2018
@mtias mtias added Future and removed Future labels Oct 7, 2018
@mtias mtias modified the milestones: Bonus Features, Future: Phase 2 Oct 7, 2018
@aduth aduth mentioned this issue May 22, 2019
Merged
@glendaviesnz glendaviesnz mentioned this issue Jun 18, 2019
Closed
@mtias
Copy link
Member

mtias commented Nov 17, 2019

Update: this is being handled through entities now. Example: #17207

@mtias mtias closed this as completed Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Block API API that allows to express the block paradigm. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@youknowriad @mtias @aduth @jeffpaul