Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block styles contain duplicated styles #27663

Closed
aristath opened this issue Dec 11, 2020 · 0 comments · Fixed by #28395
Closed

Block styles contain duplicated styles #27663

aristath opened this issue Dec 11, 2020 · 0 comments · Fixed by #28395
Assignees
@aristath
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Needs Dev Ready for, and needs developer efforts [Package] Base styles /packages/base-styles [Status] In Progress Tracking issues with work in progress [Type] Build Tooling Issues or PRs related to build tooling

Comments

@aristath
Copy link
Member

Describe the bug

Came up in #25220 (comment)

The build worker for Sass files adds _default-custom-properties.scss to all compiled files:

gutenberg/bin/packages/build-worker.js

Lines 112 to 116 in 5060734

.concat(
file.includes( 'editor-styles.scss' )
? []
: [ 'default-custom-properties' ]
)

The default-custom-properties file only contains styles for the admin-color scheme so should only be added to editor styles.

cc @gziolo who initially reported the issue in the PR.
@aristath aristath added [Type] Build Tooling Issues or PRs related to build tooling CSS Styling Related to editor and front end styles, CSS-specific issues. [Package] Base styles /packages/base-styles labels Dec 11, 2020
@gziolo gziolo added the Needs Dev Ready for, and needs developer efforts label Dec 12, 2020
@gziolo gziolo mentioned this issue Jan 5, 2021
Merged
@aristath aristath mentioned this issue Jan 21, 2021
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aristath aristath

Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Needs Dev Ready for, and needs developer efforts [Package] Base styles /packages/base-styles [Status] In Progress Tracking issues with work in progress [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't add default-custom-properties styles to all compiled files WordPress/gutenberg
2 participants
@aristath @gziolo