Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Pagination Block warning #28014

Closed
scruffian opened this issue Jan 6, 2021 · 2 comments
Closed

Query Pagination Block warning #28014

scruffian opened this issue Jan 6, 2021 · 2 comments
Labels
[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.

Comments

@scruffian
Copy link
Contributor

Describe the bug
When the perPage attribute is removed from the block it throws a warning (WordPress/theme-experiments#149 (comment)). We should default this to the WordPress setting when it's missing.
@scruffian scruffian added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block labels Jan 6, 2021
@ntsekouras
Copy link
Contributor

Query Pagination in general doesn't work well with all the new changes in Query. I plan to work on it these weeks.

@ntsekouras
Copy link
Contributor

Closing this as QueryPagination has been changed here: #28125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scruffian @ntsekouras