Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editing: Make notice about switching to template editing "sticky" & dismissible #28175

Closed
annezazu opened this issue Jan 13, 2021 · 6 comments
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Describe the bug

When switching from post editing to template editing, there's a notice that pops up to explain template editing but it disappears quite rapidly. Because this is such a big switch to be making, it seems smart to make this "stickier" and perhaps consider force people to dismiss it upon first switching over. I imagine this will be annoying if you're doing lots of edits back and forth so perhaps it would be good to make it a bit more intelligent ;). I'll leave this to design to think about the implications of.

From @priethor who helped test this: "Also, when switching from the Post editor to the Template Editor, the “Editing template” notification at the bottom was easy to miss on bigger screens."

To reproduce
Steps to reproduce the behavior:

  1. Install Gutenberg 9.6+ and a FSE ready theme.
  2. Go to Posts > Add New
  3. Make some changes to the post > Save Draft or Publish.
  4. Use the option to edit the template to switch into template editing mode in the post settings section.
  5. See the notice pop up.

Expected behavior

I expect the notice to stick around for longer and/or to be more "in the user's face".

Screenshots

Screen Shot 2021-01-13 at 12 44 19 PM

Editor version (please complete the following information):

  • WordPress version: 5.6
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Gutenberg
  • If the Gutenberg plugin is installed, which version is it? 9.7.2

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 87.0.4280.141
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Full Site Editing labels Jan 13, 2021
@annezazu
Copy link
Contributor Author

Noting here too that this might be bandaiding a root issue that, when the root issue is addressed (making post vs template editing clearer), this then becomes irrelevant :)

@priethor
Copy link
Contributor

Noting here too that this might be bandaiding a root issue that, when the root issue is addressed (making post vs template editing clearer), this then becomes irrelevant :)

I totally agree with this point of view, my feedback was based on the fact that the popup is actually the main way for users to understand they have switched to template editing mode, which is otherwise easy to miss. With a clearer distinction between editing modes, the popup discreetness would be absolutely fine, in my opinion.

@jasmussen
Copy link
Contributor

I would agree with the commentary here — I think the real solution is a very clear visual change from editing the post to editing the entire template. I've been discussing literal zooming out, when you enter template mode, with @jameskoster. I believe once that shift is noticable enough, we won't need to change the snackbar component to afford a dismiss button.

Furthermore, any changes you actually make to the template, you have to confirm again before saving, with the "Apply" button, which lists every change before you publish it.

@priethor
Copy link
Contributor

I believe this that we are talking about would be solved in #27849.

@ridesirat
Copy link

I believe this that we are talking about would be solved in #27849.

I think so too

@annezazu
Copy link
Contributor Author

Closing this out as the current notice does stick and, if you click on it, you can dismiss it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants