Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Block: Positioning regression #28242

Closed
sirreal opened this issue Jan 15, 2021 · 6 comments · Fixed by #28287
Closed

Cover Block: Positioning regression #28242

sirreal opened this issue Jan 15, 2021 · 6 comments · Fixed by #28287
Assignees
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Milestone

Comments

@sirreal
Copy link
Member

sirreal commented Jan 15, 2021

Description

Cover block has a visual regression in 9.8 RC1 with positioning in the editor.

Expected (9.7)
Screen Shot 2021-01-15 at 17 07 10

Actual (9.8 RC1)

Screen Shot 2021-01-15 at 17 06 22

Step-by-step reproduction instructions

  1. Use Gutenberg 9.8 RC1
  2. Add a Cover block
  3. Change the background position
  4. Observe the visual regression

WordPress information

  • WordPress version: 5.6
  • Gutenberg version: 9.8.0-rc.1
  • Are all plugins except Gutenberg deactivated? yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? yes
@sirreal
Copy link
Member Author

sirreal commented Jan 15, 2021

CC @ajlende May be related to #25171

@sirreal sirreal added this to the Gutenberg 9.8 milestone Jan 15, 2021
@sirreal sirreal added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Regression Related to a regression in the latest release CSS Styling Related to editor and front end styles, CSS-specific issues. labels Jan 15, 2021
@sirreal
Copy link
Member Author

sirreal commented Jan 15, 2021

The issue is not limited to the editor. See the published post:

Expected (9.7)

Screen Shot 2021-01-15 at 17 21 28

Actual (9.8 RC1)

Screen Shot 2021-01-15 at 17 21 18

@jasmussen
Copy link
Contributor

I recall a very recent PR that removed a height: 100%; value from cover, that seems potentially related. I can't recall which PR, but I recall pinging @senadir, do you recall and/or think this might be related?

@ockham
Copy link
Contributor

ockham commented Jan 18, 2021

I recall a very recent PR that removed a height: 100%; value from cover, that seems potentially related. I can't recall which PR,

@jasmussen This one? #28114

@jasmussen
Copy link
Contributor

That's the one! Thank you. I've reproduced an issue:

Screenshot 2021-01-18 at 13 39 30

Adding back height: 100%; fixes it, but so does overflow: hidden;, so I'm going to try a PR with that.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 18, 2021
@jasmussen
Copy link
Contributor

I believe that #28287 fixes this issue. I'm not completely sure, so would appreciate your eyes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants