-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Keyboard shortcuts behavior to navigate back from the block's toolbar #3003
Comments
This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs. |
More info:
At this point, focus is moved back to the block container: Ideally it should be moved back to the selection (or insertion point if no selection). For "non-editable" blocks (image, audio, video, and the like): not sure, maybe the block container is |
Some part of this issue have been addressed, for example moving focus back to the selection / insertion point in an editable area is implemented. Closing in favor of #5840 and the ongoing effort in #6302. Will split the part related to the different behavior when clicking buttons in a separate issue. |
Splitting this out from #2960 (comment)
See also the new fixed toolbar at the top: #2998
#2960 is going to add shortcuts to:
However, when pressing Escape, focus is moved back to the block container
.editor-visual-editor__block.is-selected
. For editable blocks, this is not the editable area. Instead, focus should be moved back:I'd say moving focus back to the container doesn't help so much the editing experience for all users, not just assistive technologies users.
See also:
https://www.w3.org/TR/wai-aria-practices/#h-note-17
The important thing to note here is the "invoking context": if the initial context is the editing area, then I jump to the toolbar and then I jump back to the block, I'd expect to be in the same context I was in initially.
One more thing:
Probably unrelated, so maybe should be addressed separately:
Not sure why, but when clicking/pressing Enter on some buttons, for example the alignment buttons, focus stays on that button. Instead, when activating other buttons, for example bold/italic/strikethrough, focus is moved back to the editing area. This is inconsistent: all buttons should behave the same. It's also different from what TinyMCE does in the classic editor, where focus is always moved back to the editing area.
The text was updated successfully, but these errors were encountered: