Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image to Navigation block #30101

Open
paaljoachim opened this issue Mar 22, 2021 · 3 comments
Open

Add image to Navigation block #30101

paaljoachim opened this issue Mar 22, 2021 · 3 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Mar 22, 2021

What problem does this address?

I am not able to insert image into Nav block.

What is your proposed solution?

Being able to insert image into navigation block. To create something like this:

Nav-with-image

It would be nice to be able to add a logo into the navigation block. Lets give permission to adding an Image block.

Screen Shot 2021-03-22 at 18 57 03

Screen Shot 2021-03-22 at 18 57 24

It would also be nice to be able to insert a Reusable block into the navigation bar.

@paaljoachim paaljoachim added [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement. labels Mar 22, 2021
@jasmussen
Copy link
Contributor

Nice one.

Instead of allowing the Image block, could we allow the Site Logo block? That seems more appropriate, and less prone to side-effects.

@jasmussen jasmussen added the [Block] Site Logo Affects the Site Logo Block label Mar 23, 2021
@paaljoachim
Copy link
Contributor Author

paaljoachim commented Mar 23, 2021

One might not want the Site Logo block but another image though. Perhaps one wants two images inside the navigation. Perhaps one wants to use icons beside each link. Adding the Image block gives the freedom to the user to decide how and where they want to add an image or images to the menu.

An example of using icons.
Screen Shot 2021-03-23 at 09 37 15

One could then add the icons to the Media Library. Then use Add Image to add each icon to the Navigation. Then adjust the padding for each menu item. I assume that padding will be available for each menu item. That is instead of having to add the Spacer block between each menu item.

@jasmussen
Copy link
Contributor

In the case of both an image inserted as a direct child of the navigation block, it's currently blocked on #29036.

The use case for icons makes sense, but technically you can already do that:

Screenshot 2021-03-23 at 09 45 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants