-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment Content Block #30574
Comments
Hey James Here I am wondering if we should have color controls (text and background). Perhaps even typography controls. "The content of the comment." Add the punctuation. An additional control might be to add border control. As well as some padding. |
Excellent feedback. I agree on all points :) If possible, it would be cool to use the design tools from #27331 for the color, padding, and typography controls. But I don't know if they are ready yet. |
At the moment we can focus on what is ready. Taking one step at a time. Of course the mockup can show controls that are not ready to be implemented, but when a developer picks up this issue and creates the block then he/she will see which controls are ready to be added. |
Hello! 👋 I would like to wrap up all the issues related to the Post Comments block to start working on a Comment Loop block as explained in this tracking issue. I'd like to make a quick summary to ensure we are aligned on this one: DescriptionDisplays the content of the comment. Potential Settings
References
Of course, any feedback is welcome 🙂 |
Hi all, 👋 I would like to create a draft PR and start working on this. @SantosGuillamot could you assign this issue to me? 😊 |
Hey, 👋 I had a few questions when I started working on this. Looking at the design @jameskoster shared, it looks like the block shows a generic message when no context is provided. I understand that this happens when the comment ID is not specified in the parent block, am I right? What should the block show when the comment ID is not correct? Is it OK showing the same message? Regarding the icon, I guess I have to create a new one inside My last question is related to the settings this block will have. I've added those that @SantosGuillamot proposed, although in the design also appear some buttons to make the text bold o italic. I'm not sure, but these settings don't seem quite possible to be added as that would modify the comment content, if I'm not mistaken. I'll keep working on adding tests and comments in the meantime. Thanks in advance. 🙂 |
Yay! I'll leave my feedback on the PR 👍 |
Here is an initial take on the design for the Comment Content block. This block should only be available in the Site Editor, and potentially only when editing certain templates (Index, Single, Singular, Page).
Design feedback is politely requested for all aspects:
Figma link here.
The text was updated successfully, but these errors were encountered: