Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACF Custom Field (ACF PRO) content not saving #3277

Closed
maddisondesigns opened this issue Nov 1, 2017 · 10 comments
Closed

ACF Custom Field (ACF PRO) content not saving #3277

maddisondesigns opened this issue Nov 1, 2017 · 10 comments
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen

Comments

@maddisondesigns
Copy link

Issue Overview

ACF (Advanced Custom Fields) content isn't saving after updating the page

Steps to Reproduce (for bugs)

  1. Install & activate ACF
  2. Create custom fields (ensure they're displayed on Pages/Posts)
  3. Edit Page/Post
  4. Add content to custom field & save page

Expected Behavior

Custom field content should save

Current Behavior

Custom field content doesn't save

Firefox 56.0.2 (64-bit)
macOS Sierra 10.12.1
Gutenberg 1.6.0

@themightyant
Copy link

themightyant commented Nov 2, 2017

Concur not working as intended, custom fields not saved. Overlay of "Updating Settings" over metabox iframe.
In Chrome a modal alert box comes up with "Changes you made may not be saved."

Gutenberg 1.6.0
Chrome 62.0.3202.75 (Official Build) (64-bit)
Windows 10 (64-bit)

@youknowriad
Copy link
Contributor

cc @BE-Webdesign Any idea about this?

@BE-Webdesign
Copy link
Contributor

BE-Webdesign commented Nov 2, 2017

Hi!

I will take things out for a spin and see what has happened. ACF definitely worked at one point.

@maddisondesigns Could you share your ACF registered fields data, it is possible one of the types of fields caused the issue, which could help me narrow down possible solutions.

@BE-Webdesign BE-Webdesign added the [Feature] Meta Boxes A draggable box shown on the post editing screen label Nov 2, 2017
@ghost
Copy link

ghost commented Nov 2, 2017

Happens with ACF Pro (=ACF 5) i think.

@maddisondesigns
Copy link
Author

@BE-Webdesign Sure, you can download the json files from here. I had two sample Field Groups set up...
https://www.dropbox.com/s/npdoeqahfqq0ps3/group_58e48c86cc51e.json?dl=0
https://www.dropbox.com/s/tb9sayjy2c34wv8/group_5911300e9f97c.json?dl=0

In case it's worth noting, one of the fields is a Gallery field, which I raised a seperate issue on (#3278).

The site I was testing this on, only has the following plugins activated:
Advanced Custom Fields PRO v5.6.4
Gutenberg v1.6.1
WooCommerce v3.2.3

@youknowriad
Copy link
Contributor

I'm not able to reproduce this, trying the simplest field "text". If there are issues with specific fields, let's raise those issues separately.

@ghost
Copy link

ghost commented Nov 21, 2017

Problem still exists in 1.7, regardless of field type.

Please follow @maddisondesigns steps above and use ACF Pro, it's a different product. Or may be https://www.advancedcustomfields.com/blog/acf-5-early-access/ .

You should not close an issue until you have investigated it correctly.

@youknowriad
Copy link
Contributor

youknowriad commented Nov 21, 2017

You should not close an issue until you have investigated it correctly.

Please read the issue properly, there's no mention of ACF Pro in the original issue thus, this is not specific to ACF

If there are issues with specific fields, let's raise those issues separately.

@youknowriad youknowriad reopened this Nov 21, 2017
@youknowriad youknowriad changed the title ACF Custom Field content not saving ACF Custom Field (ACF PRO) content not saving Nov 21, 2017
@maddisondesigns
Copy link
Author

@youknowriad Why was this closed? You mention that I didn't specifically say that it was the Pro version in the title, which is correct, but you've changed that now. The fact remains, that Gutenberg still breaks ACF Pro. Can you please re-open this.

@BE-Webdesign
Copy link
Contributor

@maddisondesigns, This is a duplicate of #3730. That is most likely why Riad closed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen
Projects
None yet
Development

No branches or pull requests

4 participants