Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block + Page Link Block: Create draft option shows when adding an existing page #33962

Open
3 tasks done
annezazu opened this issue Aug 10, 2021 · 2 comments
Open
3 tasks done
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Have you tried deactivating all plugins except Gutenberg?

  • I have tested with all plugins deactivated.

Have you tried replicating the bug using a default theme e.g. Twenty Twenty?

  • I have tested with a default theme.

Description

The Navigation Block's Page Link Block still shows the option to create a draft even when a page with the same title exists. This could lead to duplicated pages with the same title, which seems unnecessary.

Step-by-step reproduction instructions

  1. Add a navigation block.
  2. Add a Page Link block and start searching for a current page title.
  3. Notice that the create draft option is still visible even for a page title that exists.

Expected Behavior

I expect to not see the option to create a draft when searching for a page whose title exists. I think it would be better if it only showed when you continued typing a new page title that's not currently available.

Current Behavior

The create a draft option still exists.

Screenshots or screen recording (optional)

Visual of the problem where I have a page already published titled "Tuition" yet when I type it in the option remains to create another draft with the same title:
Screen Shot 2021-08-09 at 10 28 14 PM

Code snippet (optional)

No response

WordPress Information

WordPress 5.8.

Gutenberg Information

Gutenberg 11.2

What browsers are you seeing the problem on?

Chrome

Device Information

Desktop

Operating System Information

MacOS

@annezazu annezazu changed the title Navigation Block + Page Link Block: Create draft shows for Navigation Block + Page Link Block: Create draft option shows when adding an existing page Aug 10, 2021
@annezazu annezazu added [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement. labels Aug 10, 2021
@jasmussen
Copy link
Contributor

Good one. While in that same area, the alignment of text here isn't ideal:

Screenshot 2021-08-10 at 08 35 00

For anyone picking this up, also worth looking at #30170 (comment) for some work-in-progress on the URL dialog itself, which might affect how a new draft button might look.

@annezazu
Copy link
Contributor Author

annezazu commented Feb 7, 2022

This is still an issue as of 12.5.3 and WordPress 5.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants