Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show transformations in the ellipsis menu #3434

Closed
jasmussen opened this issue Nov 10, 2017 · 8 comments · Fixed by #3458
Closed

Show transformations in the ellipsis menu #3434

jasmussen opened this issue Nov 10, 2017 · 8 comments · Fixed by #3458
Assignees
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

Issue Overview

We've recently added "convert to blocks" as an option to the block level ellipsis menu on the Classic Text block. This feels like a natural place for this, since it's an advanced transformation at the block level.

Should we show other transforms in this menu? This would be a pattern that we could reuse from the current "Switcher" interface.

Mockups

When selecting on a single block:

single select transform

When multiple blocks are selected:

multi select transform

In these mockups we show the most obvious transformation directly (that would be gallery when selecting multiple images, or perhaps quote when selecting multiple text blocks), as well as a "Transform into" popout menu.

Is this a good design? Is the popout menu too complex? Do we think it might be a scalable pattern to show all transformations directly in the menu?

Perhaps this issue could be tackled in phases, to test what works.

@jasmussen jasmussen added Design Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. labels Nov 10, 2017
@StaggerLeee
Copy link

Looks very modern and nice. At least for me.

@hedgefield
Copy link

Yeah this makes sense! I think it would also solve the issue we found where people don't notice or recognize the block switcher in the toolbar (especially now that it has been moved to the top bar). Smart thinking to put them in a foldout menu also, the list might get quite long.

@youknowriad
Copy link
Contributor

First, I'd like to say that I like this idea a lot. Moving the switcher to this menu. A small concern I have with this design is the double "popover". You need to open the foldout menu, hover (or click) the "Turn Into" button to show the transformations.

I'd be in favor of showing all the transformations in the foldout menu after the separator.

@jasmussen
Copy link
Contributor Author

I'd be in favor of showing all the transformations in the foldout menu after the separator.

I think that's fine, especially as a start. Then we can see what becomes necessary.

@karmatosed
Copy link
Member

I really like this idea, to me it's the kind of magical nudge that takes the experience to one that really engages people. I like having after the separator also.

@rileybrook
Copy link

rileybrook commented Nov 14, 2017

In these mockups we show the most obvious transformation directly (that would be gallery when selecting multiple images, or perhaps quote when selecting multiple text blocks)

Could you envision the set of rules required for "most obvious transformation" becoming too complicated? That complexity could be reduced by leaving "most obvious transformation" out of the foldout menu and just showing all transformation options, as planned for these early stages.

@jasmussen
Copy link
Contributor Author

jasmussen commented Nov 15, 2017

Could you envision the set of rules required for "most obvious transformation" becoming too complicated? That complexity could be reduced by leaving "most obvious transformation" out of the foldout menu and just showing all transformation options, as planned for these early stages.

I can come up with a couple of opinions, but you make a solid point: perhaps we don't want to be arbiters of which transformations are "the most obvious".

@jorgefilipecosta
Copy link
Member

Regarding the "obvious transformations", I think our approach to making a test with no distinction between obvious and non-obvious is good, maybe we don't need this at all. But if we take the conclusion that we need this distinction, I think It should be up to the transform implementor to use a flag that sets that his transformation is important, the downside his every block developer want's to give relevance to his blocks so we may end up with many "obvious" transformations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants