Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Query Loop block #34996

Closed
SantosGuillamot opened this issue Sep 21, 2021 · 7 comments · Fixed by #35231 or #36065
Closed

Comments Query Loop block #34996

SantosGuillamot opened this issue Sep 21, 2021 · 7 comments · Fixed by #35231 or #36065
Assignees
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress

Comments

@SantosGuillamot
Copy link
Contributor

SantosGuillamot commented Sep 21, 2021

Description

An advanced block that allows displaying the comments of a specific post based on different parameters and visual configurations. It should be similar to the Query Loop block.

This block is part of the Post Comments Loop block, for more context please visit this Tracking Issue or its GitHub project.

Potential Settings

  • Layout settings: It should be similar to the ones in the Query Loop.
    • It can inherit the default layout or change the width and content.
    • It could be nice to be able to select the content and width (or the padding) of the child comments.
  • Color settings: It should be the same as the Query Loop.
  • Loop settings:
    • Order by: There is a Discussion Setting to select the order of the comments. I guess we should use this by default unless they change it in the Comment Loop block.
  • List view settings. We can replicate the settings in the Query Loop:
    • Items per page: There is a Discussion Setting to select how many top level comments users want per page. I think we should respect that unless it is changed in the block itself.
    • Offset.
    • Max pages.
  • Advanced settings: We can replicate the behaviour in the Query Loop:
    • HTML element: Allow users to select if they want a <div> , <section> , <aside> HTML element.

References

  • This should be similar to the Query Loop block: Guide and GitHub.
@SantosGuillamot SantosGuillamot added [Feature] Blocks Overall functionality of blocks [Feature] Full Site Editing [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop labels Sep 21, 2021
@SantosGuillamot SantosGuillamot added the New Block Suggestion for a new block label Sep 21, 2021
@michalczaplinski
Copy link
Contributor

Could you assign the issue to me @SantosGuillamot? It seem that I cannot do it myself as a contributor. Thanks!

@michalczaplinski
Copy link
Contributor

Hi @jameskoster! Do you have a design for the icon for this block?

@jameskoster
Copy link
Contributor

jameskoster commented Sep 30, 2021

Ah, no we don't. It's probably safe to use the regular loop block for now, and we can explore design for a dedicated comment loop block later. I'm not 100% sure we need one.

Edit: Actually, the Post Comments icon might make more sense than the regular loop icon. It doesn't look as 'loopy' but will probably be adequate.

@SantosGuillamot SantosGuillamot changed the title Post Comments Query Loop block Comments Query Loop block Oct 8, 2021
@gziolo
Copy link
Member

gziolo commented Oct 28, 2021

This block needs more work so let's reopen the issue.

@gziolo gziolo reopened this Oct 28, 2021
@SantosGuillamot
Copy link
Contributor Author

Great! Is there any place to check which tasks are left to consider this issue done?

@gziolo
Copy link
Member

gziolo commented Oct 28, 2021

The comment #35231 (comment) from @michalczaplinski should be a good summary of what's left.

@michalczaplinski
Copy link
Contributor

Continuing adding features and improvements to the Comments Query and Comment Template in #36065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress
Projects
None yet
4 participants