Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block Tracking Issue i2 #35521

Closed
30 of 38 tasks
priethor opened this issue Oct 11, 2021 · 21 comments
Closed
30 of 38 tasks

Navigation Block Tracking Issue i2 #35521

priethor opened this issue Oct 11, 2021 · 21 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@priethor
Copy link
Contributor

priethor commented Oct 11, 2021

Supersedes #27593

With most of the work in #27593 in place, it is a good time to revisit the Navigation block priorities with a near-future release in mind. Instead of mass-editing the existing issue, let's close it and leave it as a snapshot of a first iteration and focus here on the next round of improvements. Bugs should be reported with the [Type] Bug label and added directly to the Navigation Project Board.

High Priority

Setup interactions & placeholders

Design customization & inner blocks

IA

General UI & Copy

Normal Priority

Setup interactions & placeholders

Design customization & inner blocks

Responsiveness & hamburger menu

Backlog


This issue aims to collect new features or enhancements that build towards a better Navigation Block experience or allow for richer designs, excluding requirements driven by compatibility with the Navigation Editor.

@priethor priethor added [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. [Block] Navigation Affects the Navigation Block labels Oct 11, 2021
@carolinan
Copy link
Contributor

I think this one is important to solve
#29401

@getdave
Copy link
Contributor

getdave commented Oct 20, 2021

There is currently an exploration underway regarding separating presentation from the underlying data (items) of a navigation. This is all to do with allowing navigations to be reused across a site.

We should check out Dan's PRs and provide feedback:

Also related is this issue about Theme switching.

@draganescu
Copy link
Contributor

Updated the issue with @talldan 's listed follow-ups.

@priethor
Copy link
Contributor Author

priethor commented Oct 22, 2021

I think this one is important to solve
#29401

Thanks for flagging that one, @carolinan! I've added it to the Navigation Block project board as a ToDo item. However, I would recommend not including bugs in tracking/overview issues, as they are more oriented to provide a feature roadmap, and including bugs makes it harder to grasp the overall progress of projects regarding their scope.

@getdave
Copy link
Contributor

getdave commented Oct 27, 2021

Update - 27th October 2021

@jasmussen
Copy link
Contributor

With the merger of #35857 (@tellthemachines 👏 ), I wonder if we shouldn't — for the sake of this tracking issue — check the box for #34041?

This will not preclude further enhancements to transforms, which is one of the most powerful aspects of the block, to the point that the feature could deserve its own tracking issue!

@getdave
Copy link
Contributor

getdave commented Nov 10, 2021

Update - 10th November 2021

  • Work has continued on making Navigations reusable across a Site and between Themes.
  • A Navigation Area block was added to facilitate the reuse of Navigations between Themes. You can now switch Themes and (if the target Theme is configured correctly) your Navigation will be preserved.
  • This works somewhat similarly to Menu Locations in classic Themes:
    • you add a Nav Area block and configure it to be Primary, Secondary or Tertiary. These terms are provided by default and denote an approximate hierarchy of navigations on a site.
    • you then insert a Nav block inside the Nav Area block. This can be used to configure presentational properties of a given Menu and is ideal for Theme Developers. Note you do not need to add any nav items at this point.
    • you then optionally add items to your Navigation block.
    • when switching Theme, assuming the new Theme also has a Navigation Area block with a matching "area" (e.g. Primary, Secondary, Tertiary), then any nav items from matching Navigation Areas on your old Theme will automatically appear in the associated location in the new Theme.
    • the navigation -> area relationship is saved via site options is a format of { "primary": 794, "secondary": 112 } where the keys are the navigation areas and the values are the post IDs of Navigation post types.
  • Lots of great work behind the scenes work on the REST API which has allowed all of the above to progress.
  • Tweaks to the UI and UX of the block itself have been ongoing.

@getdave
Copy link
Contributor

getdave commented Nov 22, 2021

WP 5.9 "Must Haves"

Below is a collation of the Issues I'm aware of that are "Must Haves" for WP 5.9, for which the Gutenberg feature freeze is the 26th November.

⚠️ Update: the list of tasks has been moved to the 5.9 overview issue under Navigation block.

I've also added these to the WP 5.9 Must Haves board.

Please note: this intentionally does not cover any bugs as these can still be fixed during the Beta phase.

@mkaz
Copy link
Member

mkaz commented Nov 22, 2021

If we want to take a harder line for "must have" I think both #36593 and #36722 could be moved if not ready.

For #36722, yes, the property name could be simplified, but there is also a reason we moved the name from menu to navigation, so personally I like the more descriptive property name, but even if we want to change later we can deprecate.

For #36593, it's a better user experience without the "Save as" button but nothing is functionally broken or an issue, so it would be good to have, but like above I wouldn't hold a release for it.

@noisysocks
Copy link
Member

noisysocks commented Nov 23, 2021

Thanks for summarising @getdave. I updated the "Navigation block" section in #36556 to be the same as your list in #35521 (comment). Let's try to use #36556 if we can as that's the issue that the 5.9 squad is referring to.

@getdave
Copy link
Contributor

getdave commented Nov 23, 2021

If we want to take a harder line for "must have" I think both #36593 and #36722 could be moved if not ready.

That's a good point. There are PRs underway to address those issues, but as you say if those aren't going to land then they could be dropped without compromising things.

@tellthemachines
Copy link
Contributor

If we want to take a harder line for "must have" I think both #36593 and #36722 could be moved if not ready.

I was given to understand that removing the dialog that forces users to name their navigation block before saving is a must have for this release. #36593 is the only issue tracking that work, since #36575 was closed.

It is important at this stage that we're all super clear about what needs to be done for 5.9, so let's please not create further confusion by mentioning issue numbers instead of explicitly referring to the features themselves.

@getdave
Copy link
Contributor

getdave commented Nov 24, 2021

Update 24th November 2021

  • A list of "Must Haves" for the Navigation block for WP 5.9 were published.
  • We're tracking these items on the main 5.9 overview issue.
  • Navigation Areas (including the block itself) are not going to be in 5.9. In fact they are now deprecated due to concerns and lack of community consensus around the UX.
  • Reusable Navigations (via the wp_navigation Custom Post) will be shipping in 5.9.
  • The final experience we are targeting for the Nav block for 5.9 will be:
    • Navigation Menus will be saved to a Custom Post and thus be reusable between Themes.
    • on Theme switch your Navigation Menu will not be automatically carried across to the Navigation block in the new Theme.
    • instead you will have to manually visit the Navigation block and select the Menu you wish to display there.
    • if no Menu is assigned to a given Navigation block, then the block will render an appropriate fallback on the front of the site. This mirrors the behaviour of wp_nav_menu for classic Themes.
    • bear in mind that when you switch Themes it is likely that a Navigation block will already exist in the new Theme. This will be preconfigured with presentation attributes. Therefore for the user, the Theme switch process will simply be a matter of assigning an existing Menu (wp_navigation Post) to the existing Navigation block.
  • We recognise this is not perfect and we fully intend to iterate and improve upon this process in WordPress 6.0. However, our priority is to land a stable experience in 5.9.

@getdave
Copy link
Contributor

getdave commented Nov 25, 2021

Update for 5.9 merge day (26th Nov 2021)

Thanks to all the hard work we’re down to the last couple of items on the “Must Haves” list.

We’d really appreciate any help with reviewing and/or coding on the following PRs/items:

Also, tangentially related in that no editor = no nav block:

If anyone is aware of any other critical items that impact on the "Must Haves" please feel free to edit this list.

Thank you 🙇

@getdave
Copy link
Contributor

getdave commented Dec 1, 2021

Update for 1st December 2021

  • All of the "Must Have" items for Nav block were merged in time for WP 5.9 Beta 1.
  • We now switch focus to resolving the [Type] Bug issues.
  • Please do pop into #feature-navigation-block-editor on Core Slack if you have a question or wish to contribute.
  • Feel free to raise an Issue to report a bug. Be sure to label it with the Block: Navigation label.

@getdave
Copy link
Contributor

getdave commented Dec 14, 2021

@uniquesolution

This comment has been minimized.

@jasmussen

This comment has been minimized.

@getdave
Copy link
Contributor

getdave commented Jan 17, 2022

Update 17th Jan 2022

@getdave
Copy link
Contributor

getdave commented Jan 26, 2022

Update 26th Jan 2022

@getdave
Copy link
Contributor

getdave commented Jan 27, 2022

As discussed with @priethor and noted in the #feature-navigation-block Slack channel I'm closing this Issue in favour of a new Tracking Issue over at #38275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

9 participants