Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all blocks are shown in Inserter when selecting the Column inner block #35530

Open
annezazu opened this issue Oct 11, 2021 · 5 comments
Open
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

When selecting the inner Column block of a Columns block from List view and try to add in a new block, the Inserter shows limited results to pick from. Unclear if this is a bug or intentional but it feels buggy currently. Perhaps we can add in a different message when it's less that "there are no results" and more about needing to select a different block to add in an additional one.

This was found as part of a hallway hangout for the FSE Outreach Program's tenth call for testing.

Step-by-step reproduction instructions

  1. Add a Columns Block.
  2. Open List View and select one of the inner Column blocks.
  3. Open the inserter and see that you can't access all blocks (ie try searching for the post comment block).

Screenshots, screen recording, code snippet

This happens if you add in a regular columns block too:

column.block.inserter.bug.mov

Environment info

  • WordPress 5.8.1
  • Gutenberg 11.6
  • Chrome on MacOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface General Interface Parts of the UI which don't fall neatly under other labels. labels Oct 11, 2021
@talldan
Copy link
Contributor

talldan commented Oct 13, 2021

The plus button at the top does insert after the selected block, so it would insert another column here.

I agree it can be confusing for blocks that contain other blocks.

It also means that when there's an empty column the quick inserter is the only option for inserting blocks. I had a similar observation with the navigation block here:
#34041 (comment)

@annezazu
Copy link
Contributor Author

annezazu commented Sep 6, 2024

Using WP 6.6.2 and GB 19.1, I was able to replicate this:

columns.block.mov

There's also a strange jumping happening when I move beyond the available block to add (column) and try to click heading. This is odd to continue to see happen considering #61873 was merged to show all blocks.

@Mamaduka
Copy link
Member

Mamaduka commented Sep 6, 2024

The original behavior was intentional. It only displayed a Column block in the inserter because it can be inserted inside the Columns. The Buttons block had/has the same behavior.

The experience changed slightly after #64048, as seen in your latest screencast. Allowed blocks are displayed at the top, followed by the remaining blocks.

P.S. Jumpiness bug is tracked separately in #64998.

@annezazu
Copy link
Contributor Author

annezazu commented Sep 7, 2024

P.S. Jumpiness bug is tracked separately in #64998.

I'm not sure how the jumpiness is being tracked here. What am I missing? :D

@talldan
Copy link
Contributor

talldan commented Sep 9, 2024

I mentioned it here (and its also mentioned in the comments that follow) - #64998 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants