Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Title block: Consider having the "Make title a link" setting on by default in Query Loop context #35741

Open
annezazu opened this issue Oct 18, 2021 · 3 comments
Labels
[Block] Post Title Affects the Post Title Block [Feature] Block Validation/Deprecation Handling block validation to determine accuracy and deprecation [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

This was brought up as part of the tenth call for testing for the FSE Outreach Program:

If I’m adding posts with the query loop, I don’t see why the “link to post” option shouldn’t be on by default. I might be missing something, but I’d personally make posts linked by default and remove the Link settings / Link to posts toggle. Who wants to create an index of posts and have no links on these posts?

Currently, if you add a pattern built into the Query Loop block, the option is on by default. However, if you add the Post Title block in isolation to the Query Loop, the option is not enabled. Here's a quick video:

post.title.block.mov

This feels similar to the navigation block having the responsive option on by default #34511

What is your proposed solution?

Consider enabling the "Make title a link" by default. cc @ntsekouras for thoughts :) as I have a feeling this is more complicated than it might appear.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Block] Post Title Affects the Post Title Block [Block] Query Loop Affects the Query Loop Block labels Oct 18, 2021
@ntsekouras
Copy link
Contributor

Consider enabling the "Make title a link" by default. cc @ntsekouras for thoughts :) as I have a feeling this is more complicated than it might appear.

Actually it is a bit as it seems we need to find a solution soon for dynamic block deprecations. See discussion: #35663.

The problem here is that while the client/editor deprecation is easy, in the server side we don't have a way to know what default value to set.. 😨

@ntsekouras ntsekouras added [Feature] Block Validation/Deprecation Handling block validation to determine accuracy and deprecation and removed [Block] Query Loop Affects the Query Loop Block labels Oct 19, 2021
@Sandstromer
Copy link

Not sure it would be such a good idea to make the Post Title a link by default, as this block is also used in templates such as Single and Page where you wouldn't really need the title to link to itself by default.

@annezazu
Copy link
Contributor Author

Thanks for the wider context @ntsekouras. As for the use case you shared @Sandstromer, I was wondering the same thing! That was the only other use case I could come up with that might make this a no-go.

I'm guessing this also ties into whether a block is context aware (post title block being added to query loop vs a template).

For now, I'll keep this issue open but will rename to make it specific to the Query loop in case this can be revisited in the future.

@annezazu annezazu changed the title Post Title block: Consider having the "Make title a link" setting on by default Post Title block: Consider having the "Make title a link" setting on by default in Query Loop context Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Title Affects the Post Title Block [Feature] Block Validation/Deprecation Handling block validation to determine accuracy and deprecation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants