Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaps in current global styles #37550

Closed
oandregal opened this issue Dec 21, 2021 · 6 comments
Closed

Gaps in current global styles #37550

oandregal opened this issue Dec 21, 2021 · 6 comments
Labels
Developer Experience Ideas about improving block and theme developer experience Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Performance Related to performance efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@oandregal
Copy link
Member

oandregal commented Dec 21, 2021

This is a tracking issue to highlight the next big steps we can tackle to implement the original vision of the global styles (merge default, theme, and user styles) to improve both the developer experience and the performance.

Absorb the two big missing style pieces via the theme.json algorithm:

Performance:

@oandregal oandregal added [Type] Performance Related to performance efforts Developer Experience Ideas about improving block and theme developer experience Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 21, 2021
@oandregal oandregal changed the title Gaps in current global styles: developer experience and performance Gaps in current global styles Dec 21, 2021
@oandregal oandregal mentioned this issue Dec 21, 2021
82 tasks
@oandregal oandregal added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Dec 22, 2021
@conatus
Copy link

conatus commented Jan 19, 2022

Hello there!

Thanks for your work on all this.

The Feature - Control UI for individual blocks

I've been tracking the movement of a specific use-case: controlling the visibility of UI controls in the Block Editor using theme.json.

For example: a theme editor wants people to be able to remove elements in the UI of the button block controls, e.g. size.

This is so they can restrict how much a user can do in order to keep the general aesthetic of the website on track and prevent the user from being overwhelmed by choices when modifying a block.

How did we get here

Here is a path for all this:

My Questions

Recognise that there is a lot going on :)

Bit conscious it feels like this feature, which there is some desire from the community for some time doesn't have an issue tracking it that is visible to engineers on your side working on it.

My questions are:

  • Is there some issue tracking this feature I have missed?
  • If not, can we create one?
  • If this isn't planned for any time soon, then where would we be able to track this?

Do let me know if this is the wrong place to comment.

Thanks so much!

@oandregal
Copy link
Member Author

Hi @conatus If I understand correctly, the question is whether there's an issue for tracking modifications to theme.json? We had an overview task in the past to plan the work ahead. Now, they're created as the needs evolve to control more of the UI and involve changes to UI, theme.json, etc.

There's also reference docs for the different versions of theme.json and we should improve the example documentation soon as well.

If you have anything specific in mind that is not implemented yet, would you create a new issue if there isn't one?

@conatus
Copy link

conatus commented Jan 19, 2022

Hi @oandregal

Thanks for your help! I will take a look at those links, but to clarify this isn't about tracking modifications to the theme.json.

What this is about is: there is some control of the Block UI on an individual block we want to not show to the user.

For example, we want to remove the ability for them to control alignment on button blocks. This is so we keep the design consistent and to restrict the number of options a user has to consider.

The closest issue I can find around this issue is #27295. I haven't read it yet, but can see you wrote it, so hopefully can point me in the right direction.

#33891 also concerns the feature I am thinking of, though doesn't to have been responded to by someone on the team.

@oandregal
Copy link
Member Author

For example, we want to remove the ability for them to control alignment on button blocks.

Hi @conatus I don't think this is something that can be disabled via theme.json at the moment. If there isn't already one, you could create an issue with this specific need. Specific issues are easier to navigate than general ones.

@conatus
Copy link

conatus commented Jan 19, 2022

Hey @oandregal

Rather than create a new issue, should we considate conversation over at #33891?

There is a lot of conversation on this feature across GitHub, including by yourself - for example #27295 - though you are suggesting this is not the same thing.

@conatus
Copy link

conatus commented Jan 19, 2022

This seems to be exactly what is needed.

https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-json/#settings-for-the-block-editor

"Settings for the block editor...What customization options should be made available or hidden from the user."

Does this make sense?

@mtias mtias mentioned this issue Jan 26, 2022
57 tasks
@adamziel adamziel moved this to Tracking issues in WordPress 6.0 Editor Tasks Mar 17, 2022
@gziolo gziolo moved this from Tracking issues to Triage in WordPress 6.0 Editor Tasks Mar 29, 2022
@mtias mtias closed this as completed May 23, 2022
Repository owner moved this from Triage to Done in WordPress 6.0 Editor Tasks May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Ideas about improving block and theme developer experience Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Performance Related to performance efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants