Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard block class to List blocks on frontend #37871

Closed
ndiego opened this issue Jan 11, 2022 · 2 comments
Closed

Add standard block class to List blocks on frontend #37871

ndiego opened this issue Jan 11, 2022 · 2 comments
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@ndiego
Copy link
Member

ndiego commented Jan 11, 2022

What problem does this address?

Currently, List blocks are rendered on the frontend as simply a <ul> or <ol> and do not include the standard block class wp-block-list. In the editor, this class is included.

Since other blocks use list markup, such as the Navigation block and Social Icons block, it can be hard for theme developers to target List blocks with custom CSS without inadvertantly targeting the list markup in other blocks.

What is your proposed solution?

I propose we update the List block to include the class wp-block-list. The frontend markup would then be <ul class="wp-block-list"> or <ol class="wp-block-list">.

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Block] List Affects the List Block labels Jan 11, 2022
@aristath aristath added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed [Type] Enhancement A suggestion for improvement. [Block] List Affects the List Block labels Jan 11, 2022
@aristath
Copy link
Member

Closing as a duplicate of #12420
PR already exists in #36676 👍

@ndiego
Copy link
Member Author

ndiego commented Jan 11, 2022

Oops my apologies for the second Issue, thanks @aristath!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants