Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FontSizePicker: Deprecate bottom margin #38720

Closed
1 of 3 tasks
mirka opened this issue Feb 11, 2022 · 0 comments · Fixed by #43062
Closed
1 of 3 tasks

FontSizePicker: Deprecate bottom margin #38720

mirka opened this issue Feb 11, 2022 · 0 comments · Fixed by #43062
Assignees
@mirka
Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress

Comments

@mirka
Copy link
Member

mirka commented Feb 11, 2022 •
edited
Loading

What problem does this address?

The FontSizePicker component currently has an inherent margin-bottom, making it hard to reuse in different contexts, since it requires a style override of an internal element. This kind of internal override is something we want to discourage.

Any outer margins, if desired, should be added by the consumer.

What is your proposed solution?

Deprecate the bottom margin (similar to #37160), following the guidelines stipulated in the devdocs.

Prerequisites:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirka mirka

Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FontSizePicker: Add flag to remove bottom margin WordPress/gutenberg
1 participant
@mirka