Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to reset custom font size back to default #38932

Closed
maddisondesigns opened this issue Feb 20, 2022 · 2 comments
Closed

No way to reset custom font size back to default #38932

maddisondesigns opened this issue Feb 20, 2022 · 2 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi

Comments

@maddisondesigns
Copy link

Description

If you set a custom font size, there's no way to reset it back to the default size. Even if you click the Set custom size icon again, to return to the dropdown, it still thinks it's using a custom size and doesn't automatically return to the default size. The only way to get back to the default size is by manually removing the text in the Size input field, or manually reselecting the Default size from the dropdown.

Vid: https://share.getcloudapp.com/P8u64Ez0

The old typography tools had a convenient Reset button that allowed you to reset back to the default size. The new UI changes to the Typography tools (and the color tools) have made them considerably worse than what they were previously. You've made changing typography settings harder and more time consuming.

The previous and better typography tools:
paragraph-block

The keyboard delay between typing the text and the numbers appearing in the Input field is also way too slow, as you can also see in the video above.

Step-by-step reproduction instructions

  • Click on a paragraph block
  • Click the Set custom size icon
  • Enter a custom font size (e.g. 80px)
  • See that there's no option to reset the custom size back to the default size
  • Click the Set custom size icon again
  • See that the control is still using the custom size you entered

Screenshots, screen recording, code snippet

No response

Environment info

WP 5.9
Twenty Twenty One
Firefox 97.0.1
macOS 12.1
No Gutenberg plugin, core only

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ntsekouras
Copy link
Contributor

👋 @maddisondesigns, thanks for creating the issue!

I think the title is a bit misleading as per your own description:

The only way to get back to the default size is by manually removing the text in the Size input field, or manually reselecting the Default size from the dropdown.

So there are ways to reset to default and most importantly you can reset values through the ToolsPanel UI, which is the direction we want to follow for reseting control values.

Screen.Recording.2022-02-21.at.11.46.35.AM.mov

There are discussions about refining the ToolsPanel UX further to make it more clear that it can be used to reset values. Check discussions in this issue: #38219

Even if you click the Set custom size icon again, to return to the dropdown, it still thinks it's using a custom size and doesn't automatically return to the default size.

This is expected and the button just switches to another UI and in addition provides useful information about the selected custom input.

@ntsekouras ntsekouras added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Feb 21, 2022
@annezazu
Copy link
Contributor

I'm going to close this issue out as I see it as a duplicate of #38219 and would love to see the convo continue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
Projects
None yet
Development

No branches or pull requests

3 participants