Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block - it's too easy to create lots of menus #39489

Closed
talldan opened this issue Mar 16, 2022 · 3 comments
Closed

Navigation Block - it's too easy to create lots of menus #39489

talldan opened this issue Mar 16, 2022 · 3 comments
Labels
[Block] Navigation Affects the Navigation Block Needs Testing Needs further testing to be confirmed.

Comments

@talldan
Copy link
Contributor

talldan commented Mar 16, 2022

What problem does this address?

I think this was always a bit of a known issue, but it'd be good to find ways to reduce the number of menus that are created in the navigation block. It's quite easy to end up in this kind of state:
Screen Shot 2022-03-16 at 4 50 06 pm

At the moment there are some options that always result in menu creation:

  • Inserting a pattern with a navigation block can result in a new menu being created
  • A theme's default template part content can result in a new menu being created

What is your proposed solution?

There are probably some quick wins. For example, if a pattern contains the same hard-coded menu structure as another existing menu, that existing menu could automatically be used instead of creating a new one. This would solve the issue outlined in #38157.

I think there's also something deeper the two use cases mentioned above have in common. Patterns often represent semantic areas as do Template Parts (e.g. header, footer). If a site has an existing menu that has the same semantic meaning as the pattern or template part, that menu could be used in the navigation block within that template part or pattern by default. This also optimizes the workflow for the user, as they don't have to select a menu or create a menu at all in many cases.

Related #38157, #36307

@github-actions
Copy link

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Sep 28, 2022
@talldan
Copy link
Contributor Author

talldan commented Sep 28, 2022

I'm happy to close this, I think there are a number of other issues on the subject or related subjects already.

Here's a link to the Nav block tracking issue for anyone interested in keeping up with progress - #38275.

@talldan talldan closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2022
@getdave
Copy link
Contributor

getdave commented Oct 4, 2022

I think the majority of the issues with accidentally creating too many menus have been resolved. There are still some outstanding however but I rarely get to the problem you highlighted in this Issue anymore as user interaction is required in order to create synced Navigation Menus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

2 participants