Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover block video can show when set to featured image. #40871

Closed
peterwilsoncc opened this issue May 6, 2022 · 0 comments · Fixed by #40873
Closed

Cover block video can show when set to featured image. #40871

peterwilsoncc opened this issue May 6, 2022 · 0 comments · Fixed by #40873
Assignees
@Mamaduka
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended

Comments

@peterwilsoncc
Copy link
Contributor

Description

If the cover block is changed from displaying a video to displaying a featured image, it will continue to display the video.

Step-by-step reproduction instructions

  1. Create a new post
  2. Insert the cover block, set it to display a video
  3. Save the post
  4. Set the post's featured image
  5. Change the cover block to use the featured image
  6. Save the post
  7. In the admin the featured post will display as expected
  8. On the front end the cover block will continue to display the video

Screenshots, screen recording, code snippet

Admin shows correctly
Screen Shot 2022-05-06 at 12 04 23 pm

Front end still shows video
front-end

Environment info

  • WordPress 5.9
  • Gutenberg Trunk
  • Browser: Firefox/macOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@peterwilsoncc peterwilsoncc added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label May 6, 2022
@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label May 6, 2022
@Mamaduka Mamaduka mentioned this issue May 6, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 6, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cover: Update background type when using featured image WordPress/gutenberg
3 participants
@Mamaduka @peterwilsoncc @priethor