Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail when run under Node v6.10.2 or earlier #414

Closed
aduth opened this issue Apr 12, 2017 · 3 comments
Closed

Tests fail when run under Node v6.10.2 or earlier #414

aduth opened this issue Apr 12, 2017 · 3 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Apr 12, 2017

Regression introduced in #399 (a71bea2)

Steps to reproduce:

  1. Install Node v6.10.2 (easiest with n or nvm)
  2. Run npm run test-unit

Expected result:

Tests pass, especially considering we define a preferred version via .nvmrc.

Actual result:

Tests fail with error:

TypeError: Object.values is not a function

Anticipated cause:

Support for the Object.values function was not added until Node 7.x .

See also: http://node.green/#ES2017-features-Object-static-methods-Object-values

Removing the transform-runtime Babel plugin from the test build means that this method is not polyfilled. We'll need to consider how to reconcile this with the Babel issue described here:

babel/babel#2877 (comment)

@aduth aduth added the [Type] Bug An existing feature does not function as intended label Apr 12, 2017
@aduth
Copy link
Member Author

aduth commented Apr 12, 2017

Related to this, our Travis configuration should probably be such that it aligns with the version defined in .nvmrc if this is the version we want to assign as "preferred".

@nylen
Copy link
Member

nylen commented Apr 14, 2017

After nvm install 7 (which put me on version 7.9.0), I had to run npm rebuild node-sass to make the build/tests work.

@youknowriad
Copy link
Contributor

Closing as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants