Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding visualizers do not work properly in the Site Editor #41823

Closed
annezazu opened this issue Jun 20, 2022 · 6 comments · Fixed by #43971
Closed

Padding visualizers do not work properly in the Site Editor #41823

annezazu opened this issue Jun 20, 2022 · 6 comments · Fixed by #43971
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Jun 20, 2022

Description

In the site editor blocks that use the placeholder illustration (see PostFeaturedImage and Cover) have an off-center bug for the dimensions visualizer.

Step-by-step reproduction instructions

  1. Use 13.5 RC1
  2. Add a cover block
  3. Set the cover block to use a featured image
  4. Add padding and notice the visualizer is off

Screenshots, screen recording, code snippet

visualizer.mov

Environment info

  • GB 13.5RC1
  • WP 6.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jun 20, 2022
@draganescu
Copy link
Contributor

I am looking into this.

@draganescu
Copy link
Contributor

I cannot reproduce on trunk @annezazu - what am I doing wrong?

cover-placeholder-visualizer.mp4

@annezazu
Copy link
Contributor Author

@draganescu try doing it in the Site Editor rather than Post Editor! I find it only happens in the Site Editor upon further testing.

@draganescu
Copy link
Contributor

Yes, in the site editor it seems the visualizer has a problem as the same can be seen with the post featured image block as well, so it does not look like a cover block issue.

@draganescu draganescu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Jun 22, 2022
@annezazu
Copy link
Contributor Author

Ah ha. I'll update the title of this issue :)

@annezazu annezazu changed the title Featured image placeholder doesn't work properly with padding visualizers Padding visualizers do not work properly in the Site Editor Jun 22, 2022
@jasmussen
Copy link
Contributor

I left some additional comments here, and it seems as if the useRootPaddingAwareAlignments property might play a factor as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants