Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to unset a color value #41866

Closed
jameskoster opened this issue Jun 22, 2022 · 4 comments · Fixed by #67116
Closed

Make it easier to unset a color value #41866

jameskoster opened this issue Jun 22, 2022 · 4 comments · Fixed by #67116
Assignees
@juanfra
Labels
[Feature] Colors Color management [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

When you set a color, it currently requires two clicks to reset it:

color.mp4

This feels like an operation that might be better served by a single-click procedure. Perhaps we could add the reset (-) icon to the color button?

Screenshot 2022-06-22 at 10 59 06

While we're here, it might also be good to reduce the vocabulary. Notice how the popover has a "Clear" action, while the design tools popover talks about "Reset"ing.
@jameskoster jameskoster added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Colors Color management labels Jun 22, 2022
@jasmussen
Copy link
Contributor

Could the minus appear on hover/focus?

@jameskoster
Copy link
Contributor Author

Totally.

@jameskoster jameskoster added the [Type] Enhancement A suggestion for improvement. label Aug 3, 2022
@jameskoster jameskoster mentioned this issue Aug 25, 2022
Open
10 tasks
@jameskoster jameskoster added the Needs Dev Ready for, and needs developer efforts label Nov 1, 2022
@richtabor richtabor added this to Polish May 10, 2023
@richtabor richtabor moved this to Needs development in Polish May 10, 2023
@kevin940726 kevin940726 self-assigned this May 15, 2023
@kevin940726 kevin940726 mentioned this issue May 26, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 26, 2023
@priethor priethor moved this from Needs development to In progress in Polish May 26, 2023
@priethor priethor removed the Needs Dev Ready for, and needs developer efforts label Aug 7, 2023
@jameskoster jameskoster mentioned this issue Dec 22, 2023
Merged
8 tasks
@juanfra juanfra mentioned this issue Nov 19, 2024
Merged
@mirka
Copy link
Member

mirka commented Nov 21, 2024

Should we be concerned that a basically identical pattern (and icon) is being used as a "Remove" button for PaletteEdit? I wonder if we should have separate icons for Clear/Reset things vs. Remove/Delete things.

@jasmussen
Copy link
Contributor

Conceptually the fact that they are the same aids understanding. In both cases you are removing a customization.

@github-project-automation github-project-automation bot moved this from In progress to Done in Polish Dec 10, 2024
@juanfra juanfra mentioned this issue Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juanfra juanfra

Labels
[Feature] Colors Color management [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Polish
Status: Done
Milestone
No milestone
6 participants
@juanfra @mirka @jameskoster @jasmussen @kevin940726 @priethor