Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme.json: Core blocks should also be defined without the core keyword #42298

Open
MaggieCabrera opened this issue Jul 10, 2022 · 4 comments
Open

Theme.json: Core blocks should also be defined without the core keyword #42298

MaggieCabrera opened this issue Jul 10, 2022 · 4 comments
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Block API API that allows to express the block paradigm. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@MaggieCabrera
Copy link
Contributor

When editing theme.json and adding styles for blocks, they should be able to be defined without the need of prefixing them with core/
@MaggieCabrera MaggieCabrera moved this to Issues Created in Ignite Build a Theme Jul 10, 2022
@kathrynwp kathrynwp added the [Type] Enhancement A suggestion for improvement. label Jul 11, 2022
@annezazu annezazu added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Jul 11, 2022
@annezazu
Copy link
Contributor

@MaggieCabrera can you share a bit more why you want to see this/how this would be advantageous?

@MaggieCabrera
Copy link
Contributor Author

@MaggieCabrera can you share a bit more why you want to see this/how this would be advantageous?

yeah, I'm sorry for the one-liner! I was trying to track some discussions I had with @mtias and he suggested this so I opened the issue. I think it's mainly for convenience so you don't need to write core/ every time, but both namings would work

@annezazu
Copy link
Contributor

Got it! Thank you :)

@scruffian scruffian mentioned this issue Jul 28, 2022
Open
68 tasks
@mtias
Copy link
Member

mtias commented Sep 10, 2022

Also for consistency with the HTML markup, where we allow core blocks to have the form of wp:heading and don't require wp:core/heading

@mtias mtias added [Feature] Block API API that allows to express the block paradigm. Developer Experience Ideas about improving block and theme developer experience labels Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Block API API that allows to express the block paradigm. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mtias @MaggieCabrera @kathrynwp @annezazu