Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accesibility: Block label and title don't consider variations #44249

Closed
t-hamano opened this issue Sep 19, 2022 · 0 comments · Fixed by #44250
Closed

Accesibility: Block label and title don't consider variations #44249

t-hamano opened this issue Sep 19, 2022 · 0 comments · Fixed by #44250
Assignees
@t-hamano
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor

Comments

@t-hamano
Copy link
Contributor

Description

Related to #42416

When a block variation is applied, data-title and aria-label attributes of the inserted block display information about the original block.

I think that these information should be taken into account for block variations as well as other text.

Step-by-step reproduction instructions

  • Insert core/post-terms (categories) block (The Category Block is a variation of the Post Terms block.).
  • Check the data-title and aria-label attributes from the browser console.

Screenshots, screen recording, code snippet

variation

Environment info

  • WordPress Version: 6.1-alpha-54198
  • Gutenberg Version: 14.1.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@t-hamano t-hamano added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor labels Sep 19, 2022
@t-hamano t-hamano self-assigned this Sep 19, 2022
This was referenced Sep 19, 2022
Closed
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 19, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Block label and title don't consider variations WordPress/gutenberg
2 participants
@priethor @t-hamano