You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently ESLint errors if there are no JSDocs on modified React component methods. IMHO, I don't think methods such as render and keyDown all need JSDocs. Additionally there have been tons of missing JSDoc warnings for a while, which is kind of frustrating to go through during development.
Screenshots / Video
The text was updated successfully, but these errors were encountered:
I've been thinking about this a bit, and I'm inclined to agree that JSDocs shouldn't be required for re-implemented component methods.
These docs have little value for parsing out of the project, as the methods are never exported - appropriate inline comments in each method are far more valuable. Much of the content in JSDocs for these methods (render(), in particular), should be in the component docs.
At any rate, the current eslint output is super spammy, and makes searching for actual problems impossible - that needs to go.
@atimmer, @ntwb: If WordPress eslint plugin can be configured to not throw warnings on re-implemented component methods, please do that. Otherwise, #4245 needs to be reverted.
Issue Overview
Currently ESLint errors if there are no JSDocs on modified React component methods. IMHO, I don't think methods such as
render
andkeyDown
all need JSDocs. Additionally there have been tons of missing JSDoc warnings for a while, which is kind of frustrating to go through during development.Screenshots / Video
The text was updated successfully, but these errors were encountered: