Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block style: ensure default for theme is properly reflected in the UI #45430

Open
annezazu opened this issue Oct 31, 2022 · 1 comment
Open
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

In chatting with @anarieldesign, she mentioned that, when creating additional block styles for buttons, no matter what style of the button you use as the default, it will always mark "Fill" as a default:

Screenshot 2022-10-24 at 12 28 23

In the above example, the 3d button dark is actually the default but the UI doesn't reflect that.

What is your proposed solution?

Ideally, a block themer could determine which is the default used and that can be somehow marked in a way that the UI can respond appropriately. This is tangentially related to this issue around how best to show default values with design tools #43082

cc @WordPress/block-themers in case others have run into this or have any thoughts here!

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Oct 31, 2022
@scruffian
Copy link
Contributor

Similar to #42297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants